Skip to content

Commit dff2e22

Browse files
authored
Refactor templates
Closes GH-6. Reviewed-by: Christian Murphy <[email protected]> Reviewed-by: Remco Haszing <[email protected]> Reviewed-by: Titus Wormer <[email protected]>
1 parent c7df0df commit dff2e22

File tree

4 files changed

+67
-49
lines changed

4 files changed

+67
-49
lines changed

.github/ISSUE_TEMPLATE/1-bug.yml

Lines changed: 38 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ body:
66
* is this really a problem?
77
* is this a problem here?
88
* can this be solved in a different way?
9+
* can this be contributed as a PR with a failing test instead?
910
type: markdown
1011
- attributes:
1112
label: Initial checklist
@@ -16,82 +17,86 @@ body:
1617
required: true
1718
- label: I agree to follow the [code of conduct](https://github.com/syntax-tree/.github/blob/main/code-of-conduct.md)
1819
required: true
19-
- label: I searched [issues](https://github.com/search?q=user%3Asyntax-tree&type=Issues) and couldn’t find anything (or linked relevant results below)
20+
- label: I searched [issues](https://github.com/search?q=user%3Asyntax-tree&type=issues) and [discussions](https://github.com/orgs/syntax-tree/discussions) and couldn’t find anything (or linked relevant results below)
2021
required: true
2122
id: initial-checklist
2223
type: checkboxes
2324
- attributes:
2425
description: |
25-
Please test using the latest version of the relevant packages to make
26-
sure your issue has not already been fixed.
27-
label: Affected packages and versions
26+
Which packages cause the bug?
27+
Please test using latest versions.
28+
Example: `[email protected]`.
29+
label: Affected package
2830
id: affected-versions
2931
type: input
3032
validations:
3133
required: true
32-
- attributes:
33-
description: |
34-
Link to repository or sandbox with runnable example of the issue.
35-
Alternatively use the next section *Steps to reproduce*.
36-
label: Link to runnable example
37-
id: runnable-example
38-
type: input
39-
validations:
40-
required: false
4134
- attributes:
4235
description: |
4336
How did this happen?
44-
Please provide a [minimal and reproducible example](https://stackoverflow.com/help/minimal-reproducible-example).
37+
38+
Provide a [minimal and reproducible example](https://stackoverflow.com/help/minimal-reproducible-example).
39+
Link to a repository or sandbox or show the code here.
40+
Remove everything that is not needed.
41+
Use plain Node and npm if possible.
4542
label: Steps to reproduce
4643
id: steps-to-reproduce
4744
type: textarea
4845
validations:
4946
required: true
5047
- attributes:
51-
description: What should happen?
52-
label: Expected behavior
53-
id: expected-behavior
48+
description: |
49+
What happens?
50+
What is wrong with the current behavior?
51+
label: Actual behavior
52+
id: actual-behavior
5453
type: textarea
5554
validations:
5655
required: true
5756
- attributes:
58-
description: What happens instead?
59-
label: Actual behavior
60-
id: actual-behavior
57+
description: |
58+
What should happen instead?
59+
Why should that happen?
60+
Why is that better than the current behavior?
61+
label: Expected behavior
62+
id: expected-behavior
6163
type: textarea
6264
validations:
6365
required: true
6466
- attributes:
65-
label: Affected runtime and version
67+
label: Runtime
6668
description: |
67-
What runtime are you using (such as `[email protected]` or `[email protected]`)?
68-
Please test using the latest version.
69+
What runtime are you using?
70+
Please test using latest versions.
71+
Example: `[email protected]` or `Chrome 131.0.6778.86`.
6972
id: runtime
7073
type: input
7174
validations:
72-
required: true
75+
required: false
7376
- attributes:
7477
description: |
75-
What package manager are you using (such as `[email protected]`)?
76-
Please test using the latest version.
77-
label: Affected package manager and version
78+
What package manager are you using?
79+
Please test using latest versions.
80+
Example: `[email protected]`.
81+
label: Package manager
7882
id: package-manager
7983
type: input
8084
validations:
8185
required: false
8286
- attributes:
8387
description: |
84-
What operating system are you using (such as `macOS Monterey 12.4`)?
85-
Please test using the latest version.
86-
label: Affected OS and version
88+
What operating system are you using?
89+
Please test using latest versions.
90+
Example: `macOS Sequoia 15.1.1`.
91+
label: Operating system
8792
id: operating-system
8893
type: input
8994
validations:
9095
required: false
9196
- attributes:
9297
description: |
9398
What tools are used to build or bundle the project?
94-
Please test using the latest version.
99+
Please test using latest versions.
95100
label: Build and bundle tools
96101
multiple: true
97102
options:
@@ -112,5 +117,5 @@ body:
112117
type: dropdown
113118
validations:
114119
required: false
115-
description: Describe a bug with a project
116-
name: 🐛 Bug report
120+
description: Report a bug
121+
name: 🐛 Bug

.github/ISSUE_TEMPLATE/2-feature.yml

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,34 +15,42 @@ body:
1515
required: true
1616
- label: I agree to follow the [code of conduct](https://github.com/syntax-tree/.github/blob/main/code-of-conduct.md)
1717
required: true
18-
- label: I searched [issues](https://github.com/search?q=user%3Asyntax-tree&type=Issues) and couldn’t find anything (or linked relevant results below)
18+
- label: I searched [issues](https://github.com/search?q=user%3Asyntax-tree&type=issues) and [discussions](https://github.com/orgs/syntax-tree/discussions) and couldn’t find anything (or linked relevant results below)
1919
required: true
2020
id: initial-checklist
2121
type: checkboxes
2222
- attributes:
23-
description: Please describe the problem you are trying to solve here.
23+
description: |
24+
Please describe the problem.
25+
26+
Forget about the particular solution you have in mind.
27+
Solution time is later!
28+
29+
What is missing? What are the use cases?
30+
Describe which use cases are important and which are nice to have.
31+
Convince the maintainers that there is a real problem.
2432
label: Problem
2533
id: problem
2634
type: textarea
2735
validations:
2836
required: true
2937
- attributes:
3038
description: |
31-
What should happen?
32-
Please describe the desired behavior.
33-
label: Solution
34-
id: solution
39+
Are there existing solutions?
40+
Can these use cases be addressed already?
41+
label: Current solutions
42+
id: alternatives
3543
type: textarea
3644
validations:
3745
required: true
3846
- attributes:
3947
description: |
40-
What are the alternative solutions?
41-
Can this be solved in a different way?
42-
label: Alternatives
43-
id: alternatives
48+
What is a better solution?
49+
Why is that better than current solutions at addressing the use cases?
50+
label: Proposed solutions
51+
id: solution
4452
type: textarea
4553
validations:
4654
required: true
4755
description: Suggest an idea
48-
name: 🚀 Feature request
56+
name: 🚀 Feature

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
blank_issues_enabled: false
22
contact_links:
33
- about: Ask questions and discuss with other community members
4-
name: 🙋 Ask a question
4+
name: 💬 Discussions
55
url: https://github.com/syntax-tree/unist/discussions

.github/pull-request-template.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,23 @@
11
<!--
22
Please check the needed checkboxes ([ ] -> [x]).
3-
Leave the comments as they are: they won’t show on GitHub.
4-
We are excited about pull requests but please try to limit the scope,
3+
Leave the comments as they are: they do not show on GitHub.
4+
5+
Please try to limit the scope,
56
provide a general description of the changes,
67
and remember it’s up to you to convince us to land it.
8+
9+
We are excited about pull requests.
10+
Thank you!
711
-->
812

913
### Initial checklist
1014

1115
* [ ] I read the support docs <!-- https://github.com/syntax-tree/.github/blob/main/support.md -->
1216
* [ ] I read the contributing guide <!-- https://github.com/syntax-tree/.github/blob/main/contributing.md -->
1317
* [ ] I agree to follow the code of conduct <!-- https://github.com/syntax-tree/.github/blob/main/code-of-conduct.md -->
14-
* [ ] I searched issues and couldn’t find anything (or linked relevant results below) <!-- https://github.com/search?q=user%3Asyntax-tree&type=Issues -->
15-
* [ ] I’ve added docs and tests or that’s not applicable
18+
* [ ] I searched issues and discussions and couldn’t find anything or linked relevant results below <!-- https://github.com/search?q=user%3Asyntax-tree&type=issues and https://github.com/orgs/syntax-tree/discussions -->
19+
* [ ] I made sure the docs are up to date
20+
* [ ] I included tests (or that’s not needed)
1621

1722
### Description of changes
1823

0 commit comments

Comments
 (0)