Improve dudect test with cropped time analysis #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Mar 20, 2025
There was a problem hiding this comment.
Check https://aeb.win.tue.nl/linux/lk/lk-8.html carefully:
Don't put the bullets. Instead, use complete sentences.
jserv
reviewed
Mar 20, 2025
dudect/fixture.c
Outdated
| @@ -74,6 +101,13 @@ static void update_statistics(const int64_t *exec_times, uint8_t *classes) | |||
|
|
|||
| /* do a t-test on the execution time */ | |||
| t_push(t, difference, classes[i]); | |||
|
|
|||
| // t-test on cropped execution times, for several cropping thresholds. | |||
There was a problem hiding this comment.
Always use C-style comments.
jserv
reviewed
Mar 20, 2025
| return *a - *b; | ||
| } | ||
|
|
||
| static void prepare_percentiles(int64_t *exec_times, int64_t *percentiles) |
There was a problem hiding this comment.
Show mathematical evidences here.
BennyWang1007
force-pushed
the
dudect_fix
branch
from
2d9fff7 to
e94f593
Compare
The original dudect collect all execution times and perform t-tests, which may be affected by outliers. The outliers could be caused by context switches, interrupts, or other system activities. This patch introduces percentile-based cropping to remove outliers. The patch adds a new function "prepare_percentiles()" to compute thresholds using an complementary exponential decay scale. The function is called before the test starts. The patch modifies "update_statistics()" to perform t-tests on cropped execution times by filtering out the outliers.
BennyWang1007
force-pushed
the
dudect_fix
branch
from
e94f593 to
0c920f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original dudect collect all execution times and perform t-tests,
which may be affected by outliers. The outliers could be caused by
context switches, interrupts, or other system activities. This patch
introduces percentile-based cropping to remove outliers.
The patch adds a new function "prepare_percentiles()" to compute
thresholds using an complementary exponential decay scale. The function
is called before the test starts.
The patch modifies "update_statistics()" to perform t-tests on cropped
execution times by filtering out the outliers.
Change-Id: Ieba005a990b122785ce931fe1364adf81dd9802a