Enhance fmtscan dictionary with HTML and CSS terms
#288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Apr 7, 2025
While working on web integration for the assignment, fmtscan marked 'href' and 'rel' from HTML, and 'monospace' from CSS, as spelling errors - a problem also seen in sysprog21#265. Add these valid terms to the dictionary to avoid false positives and ensure reliable static analysis. This fixes the flagging issue from sysprog21#265 but leaves its request for better error details in fmtscan unaddressed. Change-Id: Ia59908e7ce9bdf4b6c9e0110d5ad061d401cbba1
HeatCrab
force-pushed
the
frontend-dict-update
branch
from
6bbe55d to
e459061
Compare
HeatCrab
changed the title
fmtscan dictionary with front-end termsfmtscan dictionary with HTML and CSS terms
|
I've updated both the PR title and description to use "HTML and CSS terms" instead, specifying that 'href' and 'rel' come from HTML, and 'monospace' from CSS. Please let me know if anything else needs improvement! |
|
Thank @HeatCrab for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the spelling dictionary with three terms - 'href' and 'rel' from HTML, and 'monospace' from CSS - that fmtscan marked as false positives during web integration. It fixes a flagging issue also seen in #265, ensuring reliable static analysis, but leaves #265's request for better error details in fmtscan unaddressed.
Related Issue: #265