-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readability #96
Conversation
This new foreground + background color maintains the minimum of 7:1 contrast ratio as specified by WCAG (this has 7.36:1) and is the same colors firefox reading mode uses when choosing the sepia theme. Fonts are too small by default, using responsive units (em) let's me increase them, I am unsure where or if there is font-size specified for parent anywhere but it seems to have been manually decreased. Increased max-width slightly to adjust for new size and more standard line-height, so the doc doesn't feel significantly longer, still maintains good eye travel.
Let me know if I edited the cfg correctly. Code syntax highlight could use a change if this were to be used. It, would need to have slightly darker colors, it's already close to having good contrast ratios for the most part. |
Also consider using better font, like Manrope. Manrope has a variable weight version and from my experience, people with accessibility issues don't struggle with it. Variable weight means you can use semi-bold which is great, it has pleasant shape and scales really well. (https://manropefont.com/) |
Manrope is an open-source modern sans-serif font family. These fonts are licensed under the Open Font License. It is great to LKMPG development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output looks promising to me after fix those minor problems.
Fixed it. if there is anything else that you want me to fix or change let me know. I find this version readable but it's good to have second opinion, perhaps you noticed something that doesn't look the way it was intended? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank @Kellegram for contributing! |
Related issue #82
This new foreground + background color maintains the minimum of 7:1 contrast ratio as specified by WCAG (this has 7.36:1) and is the same colors firefox reading mode uses when choosing the sepia theme.
Fonts are too small by default, using responsive units (em) let's me increase them, I am unsure where or if there is font-size specified for parent anywhere but it seems to have been manually decreased.
Increased max-width slightly to adjust for new size and more standard line-height, so the doc doesn't feel significantly longer, still maintains good eye travel.