Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability #96

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Improve readability #96

merged 2 commits into from
Sep 9, 2021

Conversation

Kellegram
Copy link
Contributor

@Kellegram Kellegram commented Sep 8, 2021

Related issue #82

This new foreground + background color maintains the minimum of 7:1 contrast ratio as specified by WCAG (this has 7.36:1) and is the same colors firefox reading mode uses when choosing the sepia theme.

Fonts are too small by default, using responsive units (em) let's me increase them, I am unsure where or if there is font-size specified for parent anywhere but it seems to have been manually decreased.

Increased max-width slightly to adjust for new size and more standard line-height, so the doc doesn't feel significantly longer, still maintains good eye travel.

This new foreground + background color maintains the minimum of 7:1 contrast ratio as specified by WCAG (this has 7.36:1) and is the same colors firefox reading mode uses when choosing the sepia theme. 

Fonts are too small by default, using responsive units (em) let's me increase them, I am unsure where or if there is font-size specified for parent anywhere but it seems to have been manually decreased.

Increased max-width slightly to adjust for new size and more standard line-height, so the doc doesn't feel significantly longer, still maintains good eye travel.
@Kellegram
Copy link
Contributor Author

Let me know if I edited the cfg correctly. Code syntax highlight could use a change if this were to be used. It, would need to have slightly darker colors, it's already close to having good contrast ratios for the most part.

@jserv jserv requested a review from fennecJ September 8, 2021 01:49
@Kellegram
Copy link
Contributor Author

Also consider using better font, like Manrope. Manrope has a variable weight version and from my experience, people with accessibility issues don't struggle with it. Variable weight means you can use semi-bold which is great, it has pleasant shape and scales really well. (https://manropefont.com/)

@jserv
Copy link
Contributor

jserv commented Sep 8, 2021

Manrope is an open-source modern sans-serif font family. These fonts are licensed under the Open Font License. It is great to LKMPG development.

Copy link
Collaborator

@fennecJ fennecJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output looks promising to me after fix those minor problems.

@jserv jserv requested a review from fennecJ September 8, 2021 19:23
@Kellegram
Copy link
Contributor Author

Fixed it. if there is anything else that you want me to fix or change let me know. I find this version readable but it's good to have second opinion, perhaps you noticed something that doesn't look the way it was intended?

Copy link
Collaborator

@fennecJ fennecJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jserv jserv marked this pull request as ready for review September 9, 2021 03:19
@jserv jserv merged commit 3b9a3bd into sysprog21:master Sep 9, 2021
@jserv
Copy link
Contributor

jserv commented Sep 9, 2021

Thank @Kellegram for contributing!

@jserv jserv mentioned this pull request Sep 9, 2021
@Kellegram Kellegram deleted the patch-1 branch September 9, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants