Use control point radius for hit detection #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 14, 2025
apps/spline.c
Outdated
Comment on lines
15
to
17
| #define control_point_radius 10 | ||
| #define backbone_width 2 | ||
| #define aux_line_width 2 |
Change the control point hit detection from spline width to a dedicated control point radius. Introduce macros to define different lengths for easier configuration. Signed-off-by: Wei-Hsin Yeh <[email protected]>
weihsinyeh
force-pushed
the
control_point
branch
from
2a78966 to
f1bbd22
Compare
|
Thank @weihsinyeh for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the control point hit detection from spline width to a dedicated control point radius. Introduce macros to define different lengths for easier configuration.
Summary by Bito
This pull request enhances the control point hit detection by replacing spline width with a defined control point radius. It introduces macros for easier adjustments of control point radius, backbone width, and auxiliary line width, along with updates to initialization and hit detection logic.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2