Fix the cursor position #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coordinates (x,y) of the cursor should not be set to the cursor's width (14) and height (20). Instead, the coordinates should be set to (0,0), ensuring that the cursor's hotspot is correctly aligned at the intended position. Signed-off-by: Wei-Hsin Yeh <[email protected]>
ndsl7109256
approved these changes
Feb 26, 2025
|
Thank @weihsinyeh for contributing! |
huaxinliao
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coordinates (x,y) of the cursor should not be set to the cursor's width (14) and height (20). Instead, the coordinates should be set to (0,0), ensuring that the cursor's hotspot is correctly aligned at the intended position.
Summary by Bito
This pull request fixes a bug in the cursor positioning logic by updating the coordinates from (14,20) to (0,0). This adjustment ensures the cursor's hotspot is correctly aligned, enhancing the overall user experience.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2