-
Notifications
You must be signed in to change notification settings - Fork 115
Fix build with clang by using llvm-ar #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
visitorckw
wants to merge
2
commits into
sysprog21:master
Choose a base branch
from
visitorckw:fix-clang-build-softfloat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3005f7f
to
bb58add
Compare
Ensure that llvm-ar and other LLVM tools from version 18 are available in the PATH during CI builds. Without this, only the versioned binaries (e.g. llvm-ar-18) are found, which can cause build failures when unversioned tool names are expected.
When building with clang and RV32F enabled, linking fails with undefined references to SoftFloat functions. For example: $ make CC=clang-18 /usr/bin/ld: /tmp/lto-llvm-28abb9.o: in function `do_fmadds': emulate.c:(.text.do_fmadds+0x3c): undefined reference to `f32_mulAdd' /usr/bin/ld: /tmp/lto-llvm-28abb9.o: in function `do_fadds': emulate.c:(.text.do_fadds+0x31): undefined reference to `f32_add' This happens because GNU ar cannot correctly archive objects compiled with clang. Switch to llvm-ar when CC is clang, ensuring the SoftFloat library is archived correctly and the build succeeds.
bb58add
to
7d2b787
Compare
I ran |
I only ran make CC=clang-18 and hit the build error.
In addition, I added the following lines in the Makefile to confirm toolchain versions: $(CC) --version
$(AR) --version The output was:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with clang and RV32F enabled, linking fails with undefined references to SoftFloat functions. For example:
$ make CC=clang-18
/usr/bin/ld: /tmp/lto-llvm-28abb9.o: in function
do_fmadds': emulate.c:(.text.do_fmadds+0x3c): undefined reference to
f32_mulAdd'/usr/bin/ld: /tmp/lto-llvm-28abb9.o: in function
do_fadds': emulate.c:(.text.do_fadds+0x31): undefined reference to
f32_add'This happens because GNU ar cannot correctly archive objects compiled with clang. Switch to llvm-ar when CC is clang, ensuring the SoftFloat library is archived correctly and the build succeeds.