Fix emcc build inheriting stale SYSTEM config#645
Merged
Conversation
The emcc build without ENABLE_SYSTEM was failing because it inherited a stale .config file from the previous 'make ENABLE_SYSTEM=1 artifact' step. This caused the build to attempt creating minimal.dtb even though SYSTEM mode was not explicitly enabled. The fix adds 'make distclean' before the emcc build without SYSTEM to ensure a clean configuration state. This mirrors the pattern already used for the SYSTEM emulation build. Root cause: The .config file persists across make invocations, and 'make ENABLE_SYSTEM=1 artifact' sets SYSTEM=1 in the config. Without distclean, subsequent builds read this stale config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emcc build without ENABLE_SYSTEM was failing because it inherited a stale .config file from the previous 'make ENABLE_SYSTEM=1 artifact' step. This caused the build to attempt creating minimal.dtb even though SYSTEM mode was not explicitly enabled.
The fix adds 'make distclean' before the emcc build without SYSTEM to ensure a clean configuration state. This mirrors the pattern already used for the SYSTEM emulation build.
Root cause: The .config file persists across make invocations, and 'make ENABLE_SYSTEM=1 artifact' sets SYSTEM=1 in the config. Without distclean, subsequent builds read this stale config.