Skip to content

Set PrimaryDisplay to hybrid graphics #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: system76
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mainboard/system76/addw1/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
memupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
memupd->FspmConfig.PrimaryDisplay = 4;

cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg);
}
4 changes: 2 additions & 2 deletions src/mainboard/system76/adl/variants/gaze17-3050/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/adl/variants/gaze17-3060-b/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/adl/variants/oryp10/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/adl/variants/oryp9/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/gaze15/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
memupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
memupd->FspmConfig.PrimaryDisplay = 4;

cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg);
}
4 changes: 2 additions & 2 deletions src/mainboard/system76/oryp5/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
memupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
memupd->FspmConfig.PrimaryDisplay = 4;

// Allow memory speeds higher than 2666 MT/s
memupd->FspmConfig.SaOcSupport = 1;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/oryp6/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
memupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
memupd->FspmConfig.PrimaryDisplay = 4;

variant_configure_fspm(memupd);

Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/rpl/variants/addw3/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/rpl/variants/bonw15/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/rpl/variants/gaze18/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/rpl/variants/oryp11/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/rpl/variants/serw13/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/mainboard/system76/tgl-h/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Enable dGPU power
nvidia_set_power(&config);

// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
// Set primary display to hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 4;

variant_memory_init_params(mupd);

Expand Down
1 change: 1 addition & 0 deletions src/mainboard/system76/tgl-u/variants/galp5/romstage.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
nvidia_set_power(&config);

// Set primary display to internal graphics
// NOTE: Use iGFX as some units don't have a dGPU for hybrid graphics
mupd->FspmConfig.PrimaryDisplay = 0;

memcfg_init(mupd, &board_cfg, &spd_info, half_populated);
Expand Down