fix: client-side simulation does not work in test #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@chungweileong94 is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
chungweileong94
commented
Dec 20, 2023
| @@ -336,17 +336,19 @@ describe("shared can be accessed on both server and client", () => { | |||
| FOO_BAR: "foo", | |||
| }; | |||
|
|
|||
| const env = createEnv({ | |||
There was a problem hiding this comment.
Previously we called createEnv before "simulate" the window object below, which mean we already get env in server mode.
Nothing change to the test result, but at least the client-side simulation is fixed.
chungweileong94
commented
Dec 20, 2023
| }); | ||
| const env = lazyCreateEnv(); | ||
|
|
||
| expect(() => env.BAR).toThrowErrorMatchingInlineSnapshot( |
There was a problem hiding this comment.
Technically we don't have to check this in this test case, but I figure why not🤷
juliusmarminge
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #156