Support passing parameters using URL fragments #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far parameters could only be passed using query strings. Since query strings are sent to the server, URI length limitations can apply. With this change we let the standalone app also parse everything that comes after the hash in the url as if it were part of the query string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far parameters could only be passed using query strings. Since query strings are sent to the server, URI length limitations can apply. While the standalone app will not send data to the server and only modify the current URL, accessing a URL generated by it (e.g. when sharing it with others) will send potentially sensitive data (like custom titles or inline query plans using
data:URLs in custom integrations) to the server.With this change we let the standalone app also parse everything that comes after
#as if it were part of the query string. Since data that comes after the hash will not be sent to the server, URL length limitations can be side-stepped and potentially sensitive data will remain local only if provided after the hash. The standalone app now also updates?-parameters to use the#-parameters, thereby making the generated URLs privacy respecting by default.