Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jetton cookbook #380

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

pixelplex
Copy link
Contributor

@pixelplex pixelplex commented Sep 5, 2024

Closes #321

@a-bahdanau
Copy link
Contributor

#321

@a-bahdanau
Copy link
Contributor

There is one TODO left in PR
forwardPayload: beginCell().storeBool(false).endCell().beginParse(), // TODO: this is so gas consuming, maybe there is another way? Or use generic (TBD)? Or there is better way to just left it

Maybe wait till 1.5 for generics? Or use another approach as u suggest

Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I've added some nits from my side.

With that, I summon @Gusarich for a better proof-read of the code :)

pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
@a-bahdanau
Copy link
Contributor

@novusnota resolved your comments

@novusnota novusnota mentioned this pull request Sep 15, 2024
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
pages/cookbook/jettons.mdx Show resolved Hide resolved
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
pages/cookbook/jettons.mdx Outdated Show resolved Hide resolved
@novusnota
Copy link
Member

@a-bahdanau @pixelplex Thanks for opening the PR and working through all the suggestions we threw at you :)

@Gusarich, thanks for helping me review this! Please notify if there is anything else before we merge it?

@novusnota novusnota merged commit d285e25 into tact-lang:main Sep 24, 2024
1 check passed
@anton-trunov
Copy link
Member

Thanks @a-bahdanau, we have a nice starting point to further enhance the cookbook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fungible tokens (jettons) in Cookbook
5 participants