Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused check.ts #1313

Merged
merged 4 commits into from
Jan 14, 2025
Merged

refactor: remove unused check.ts #1313

merged 4 commits into from
Jan 14, 2025

Conversation

verytactical
Copy link
Contributor

@verytactical verytactical commented Jan 14, 2025 •
edited
Loading

Issue

check.ts is not used anywhere.

Towards #1269.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@verytactical verytactical requested a review from a team as a code owner January 14, 2025 12:01
@verytactical verytactical mentioned this pull request Jan 14, 2025
Closed
11 tasks
@i582
Copy link
Contributor

i582 commented Jan 14, 2025

Is there another way to run just the check without compiling?

@anton-trunov
Copy link
Member

Is there another way to run just the check without compiling?

we have exposed the type checker via --check CLI flag and it does not use this file, so there is no point in keeping it

@anton-trunov
Copy link
Member

btw, misti does not use this file, so we won't break it with this change

anton-trunov
anton-trunov reviewed Jan 14, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
anton-trunov
anton-trunov reviewed Jan 14, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 14, 2025
@anton-trunov anton-trunov self-assigned this Jan 14, 2025
@anton-trunov anton-trunov merged commit ffb448e into main Jan 14, 2025
17 checks passed
@anton-trunov anton-trunov deleted the remove-check branch January 14, 2025 12:36
@anton-trunov anton-trunov changed the title refactor: remove check.ts refactor: remove unused check.ts Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov left review comments

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@verytactical @i582 @anton-trunov