Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split build scripts #1339

Merged
merged 4 commits into from
Jan 16, 2025
Merged

refactor: split build scripts #1339

merged 4 commits into from
Jan 16, 2025

Conversation

verytactical
Copy link
Contributor

Issue

Towards #1269.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@verytactical verytactical requested a review from a team as a code owner January 14, 2025 16:36
@verytactical verytactical force-pushed the move-stdlib branch 4 times, most recently from 747327a to e34b869 Compare January 14, 2025 17:09
anton-trunov
anton-trunov previously approved these changes Jan 14, 2025
View reviewed changes
anton-trunov
anton-trunov previously approved these changes Jan 14, 2025
View reviewed changes
@verytactical verytactical mentioned this pull request Jan 14, 2025
Closed
11 tasks
@anton-trunov anton-trunov self-assigned this Jan 16, 2025
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 16, 2025
@anton-trunov anton-trunov mentioned this pull request Jan 16, 2025
Open
anton-trunov
anton-trunov approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI actually silently fails on Windows. This will be resolved in a follow-up refactoring: #1353

@anton-trunov anton-trunov merged commit 1756916 into main Jan 16, 2025
17 checks passed
@anton-trunov anton-trunov deleted the move-stdlib branch January 16, 2025 15:14
@verytactical verytactical mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@verytactical @anton-trunov