Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pretty-printer): support AstTypedParameter AST node #1347

Merged

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 16, 2025

Issue

Closes #1040.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases

Do we have any tests for things like this?

  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 requested a review from a team as a code owner January 16, 2025 08:12
CHANGELOG.md Outdated
@@ -51,6 +51,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- 'The "remainder" field can only be the last field:' inspection now shows location: PR [#1300](https://github.com/tact-lang/tact/pull/1300)
- Forbid "remainder" field at the middle of a contract storage: PR [#1301](https://github.com/tact-lang/tact/pull/1301)
- Forbid the `override` modifier for functions without the corresponding super-function: PR [#1302](https://github.com/tact-lang/tact/pull/1302)
- Support all remaining AST nodes in pretty printer: PR [#1347](https://github.com/tact-lang/tact/pull/1347)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's list the AST nodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@anton-trunov
Copy link
Member

Do we have any tests for things like this?

yep, you even fixed those tests in PR #1346

@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 16, 2025
@anton-trunov anton-trunov self-assigned this Jan 16, 2025
@i582
Copy link
Contributor Author

i582 commented Jan 16, 2025

Do we have any tests for things like this?

yep, you even fixed those tests in PR #1346

ehehe, I meant tests for specific nodes :D

@i582 i582 changed the title fix(pretty-printer): support all remaining AST nodes fix(pretty-printer): support AstDestructMapping, AstDestructEnd, and AstTypedParameter AST nodes Jan 16, 2025
src/prettyPrinter.ts Outdated Show resolved Hide resolved
src/prettyPrinter.ts Outdated Show resolved Hide resolved
@i582 i582 changed the title fix(pretty-printer): support AstDestructMapping, AstDestructEnd, and AstTypedParameter AST nodes fix(pretty-printer): support AstTypedParameter AST node Jan 16, 2025
@anton-trunov anton-trunov merged commit 4dbbf40 into main Jan 17, 2025
18 of 19 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/support-all-unsupported-ast-nodes-in-pretty-printer branch January 17, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty-printer doesn't support several types of AST nodes
3 participants