Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codegen): rearrange parameters of asm methods in order described in Asm Shuffle #1702

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(codegen): rearrange parameters of asm methods in order described in Asm Shuffle #1702

wants to merge 9 commits into from
+358 −284

Conversation

i582
Copy link
Contributor

@i582 i582 commented Feb 4, 2025 •
edited by novusnota
Loading

Support only some asm functions:

  • is method
  • non mutable
  • without return rearrangement

Example:

asm(value self) extends fun storeBool(self: Builder, value: Bool): Builder { 1 STI }

Issue

Closes #1571.
Towards #1584.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Feb 4, 2025
anton-trunov
anton-trunov requested changes Feb 5, 2025
View reviewed changes
src/generator/writers/writeExpression.ts Outdated Show resolved Hide resolved
src/generator/writers/writeExpression.ts Outdated Show resolved Hide resolved
@i582 i582 marked this pull request as ready for review February 7, 2025 10:52
@i582 i582 requested a review from a team as a code owner February 7, 2025 10:52
@i582 i582 requested a review from anton-trunov February 7, 2025 10:52
novusnota
novusnota previously approved these changes Feb 7, 2025
View reviewed changes
anton-trunov
anton-trunov requested changes Feb 7, 2025
View reviewed changes
src/test/benchmarks/jetton/results.json Outdated
@@ -54,11 +54,17 @@
"burn": "16029",
"discovery": "10093"
},
{
"label": "1.5.3 with improved storeBool",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add the link to this PR or some other way of identifying the exact version of Tact here (the commit hash will be known only after we squash and merge)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/generator/writers/writeFunction.ts Outdated
Comment on lines 584 to 585
let functionParams = params;
let needShuffle = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't use mutation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/generator/writers/writeFunction.ts Outdated
Comment on lines 603 to 608
const paramsDict = Object.fromEntries(
params.map((param, i) => [
i === 0 ? "self" : f.params[i - 1]!.name.text,
param,
]),
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we somehow reuse the code from writeExpression?

verytactical
verytactical approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@verytactical verytactical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov requested changes

@verytactical verytactical verytactical approved these changes

@novusnota novusnota novusnota left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Reverse __tact_store_bool parameters to remove extra SWAP
4 participants
@i582 @anton-trunov @novusnota @verytactical