Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include expected type for invalid type error message #1738

Merged
merged 5 commits into from
Feb 10, 2025
Merged

feat: include expected type for invalid type error message #1738

merged 5 commits into from
Feb 10, 2025

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Feb 7, 2025

Issue

Closes #1724.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.6.0 milestone Feb 7, 2025
@Gusarich Gusarich requested a review from a team as a code owner February 7, 2025 10:55
i582
i582 previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@i582 i582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anton-trunov
anton-trunov requested changes Feb 10, 2025
View reviewed changes
anton-trunov
anton-trunov previously approved these changes Feb 10, 2025
View reviewed changes
@anton-trunov
Copy link
Member

ah, merge conflicts

@anton-trunov anton-trunov merged commit 61885b2 into tact-lang:main Feb 10, 2025
22 checks passed
github-actions bot pushed a commit to TownSquareXYZ/tact that referenced this pull request Feb 11, 2025
@Gusarich @github-actions
feat: include expected type for invalid type error message (tact-lang…
97864b8 
…#1738)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@i582 i582 Awaiting requested review from i582

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Error Invalid type "<null>" for argument "to" should include expected type
3 participants
@Gusarich @anton-trunov @i582