Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stdlib): send() costs less gas #1800

Merged
merged 17 commits into from
Feb 14, 2025
Merged

refactor(stdlib): send() costs less gas #1800

merged 17 commits into from
Feb 14, 2025

Conversation

Shvandre
Copy link
Contributor

@Shvandre Shvandre commented Feb 12, 2025 •
edited
Loading

Issue

Closes #1770 .
Closes #1820 .

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Shvandre Shvandre requested a review from a team as a code owner February 12, 2025 20:35
@Shvandre
Copy link
Contributor Author

Shvandre commented Feb 12, 2025 •
edited
Loading

Tests for new function will be added in next commit. For now I just want @novusnota @anton-trunov @Gusarich (And anyone who is interested) to look at this function, maybe this can be optimized even more.

@anton-trunov anton-trunov added this to the v1.6.0 milestone Feb 13, 2025
@anton-trunov anton-trunov self-assigned this Feb 13, 2025
@Shvandre Shvandre changed the title Added deploy function Improved send() function Feb 13, 2025
@Shvandre
update
b742107
@Shvandre
update
e0a2a33
@Shvandre
Merge branch 'main' into AddedDeployFunction
0fa932b 
# Conflicts:
#	src/stdlib/stdlib.ts
#	src/stdlib/stdlib/std/internal/send.tact
@novusnota novusnota self-requested a review February 13, 2025 15:16
@anton-trunov
Copy link
Member

stdlib.ts is out of sync

@anton-trunov anton-trunov changed the title Improved send() function refactor(stdlib): send() costs less gas Feb 13, 2025
@novusnota
Copy link
Member

I've reordered the fields of SendParameters in the docs, and since this isn't a breaking change I didn't add a note.

The note will be added as per #1771 on the Assembly functions page

novusnota
novusnota previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-trunov
Copy link
Member

conflicts with src/test/benchmarks/jetton/results.json

@novusnota
Copy link
Member

novusnota commented Feb 13, 2025 •
edited
Loading

Needs yarn bench

@anton-trunov
Copy link
Member

@Shvandre you also need to update the improved escrow tests

@anton-trunov anton-trunov merged commit 4bcc0aa into main Feb 14, 2025
25 checks passed
@anton-trunov anton-trunov deleted the AddedDeployFunction branch February 14, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov requested changes

@novusnota novusnota novusnota approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

StateInit can be inlined in send() Reorder fields of SendParameters to save gas in send
3 participants
@Shvandre @anton-trunov @novusnota