Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ods): support consecutive repeated empty cells #456

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

PrettyWood
Copy link
Contributor

@PrettyWood PrettyWood commented Aug 10, 2024

closes #455

Explanation

We had two files: single-empty.ods that worked fine and multi-empty.ods that didn't
Why? Because for single-empty.ods the XML behind it only has one empty with table:table-row table:number-rows-repeated="7" whereas multi-empty.ods has one empty, one with table:table-row table:number-rows-repeated="4" and then one with table:table-row table:number-rows-repeated="2"

The code didn't support consecutive empty lines. I tried to make as little change as possible but there might well be a better way

@alexander-beedie
Copy link

Nice one.

@archqt
Copy link

archqt commented Aug 15, 2024

A new version 1.5.0-1 is available for me on Archlinux, and still the same it doesn't work.

@tafia tafia merged commit 003620b into tafia:master Sep 16, 2024
4 checks passed
@tafia
Copy link
Owner

tafia commented Sep 16, 2024

Thanks!

@PrettyWood PrettyWood deleted the fix/455 branch September 16, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange failure to determine string dtype column in ODS sheet/file
4 participants