ran cargo clippy --fix -- -Wclippy::use_self

[adamnemecek]

Summary by CodeRabbit

• Refactor
  • Internal code style improvements with no impact on functionality or user-facing features.

[coderabbitai]

Walkthrough

This pull request refactors multiple source files in the gh-workflow crate to replace explicit type names with the Self type alias in constructors, return types, trait implementations, and pattern matching contexts. The refactoring maintains existing behavior and public APIs while improving code consistency and style.

Changes

Cohort / File(s)	Summary
Core Type Constructors crates/gh-workflow/src/cargo.rs, crates/gh-workflow/src/container.rs, crates/gh-workflow/src/step.rs	Updated constructors to return Self instead of explicit type names; modified constructor expressions from TypeName { ... } to Self { ... }. Public signatures for Step<Use>::checkout() and Step<Toolchain>::toolchain() updated to return Self.
Context Type Refactoring crates/gh-workflow/src/ctx.rs	Updated Context<A>::new(), eq(), and(), or(), and concat() methods to use Self in signatures and construction. Pattern matching updated from Step::* variants to Self::*. Trait implementation From<Context<A>> for Expression and From<T> for Context<String> refactored to use Self-based construction.
Environment and Configuration crates/gh-workflow/src/env.rs, crates/gh-workflow/src/rust_flag.rs	Constructor invocations and trait implementations (From impls) updated to use Self(...) instead of explicit type names. Helper methods in RustFlags (allow, warn, deny, forbid, codegen) refactored to return Self::Variant instead of RustFlags::Variant. Display implementations updated to use Self in pattern matching.
Job and Toolchain Types crates/gh-workflow/src/job.rs, crates/gh-workflow/src/toolchain.rs	Constructor calls in From trait implementations replaced with Self(...). Display implementations and enum variants refactored to use Self::Variant pattern matching instead of explicit enum type names.
Release Plz Configurations crates/gh-workflow/src/release_plz.rs	Display implementations for Command and Backend enums updated to use Self::* variants instead of explicit enum names in pattern matching.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

While the refactoring spans 8 files, each change follows a consistent, low-risk pattern of replacing explicit type names with Self. The modifications are straightforward syntactic updates with no behavioral changes or public API alterations, making individual reviews predictable despite the broad scope.

Poem

🐰 A rabbit's refactoring rhyme:

Self, not names—let types unfold,
From concrete paths to Self we're told,
Eight little files, one pattern true,
Consistency blooms in all we do!
✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 29.27% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "ran cargo clippy --fix -- -Wclippy::use_self" accurately and specifically describes the main change in the changeset. The entire PR consistently applies the clippy::use_self lint fix across all modified files, replacing explicit type names with the Self keyword in constructors, return types, and pattern matching throughout multiple source files. The title is clear, specific, and conveys exactly what was done—a developer reviewing the history would immediately understand that this is an automated clippy fix applied systematically to the codebase.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/gh-workflow/src/ctx.rs (1)

59-87: Parameter type changes are correct.

The replacement of explicit type with Self in the other parameter is appropriate and improves code consistency.

Consider moving instead of cloning for consistency.

Since other is owned (taken by value), you could move other.step directly instead of cloning it in eq, and, and or methods. This would be consistent with the concat method (line 96) and eliminate unnecessary clones:

 pub fn eq(&self, other: Self) -> Context<bool> {
     Context {
         marker: Default::default(),
         step: Step::Eq {
             left: Box::new(self.step.clone()),
-            right: Box::new(other.step.clone()),
+            right: Box::new(other.step),
         },
     }
 }

Apply the same pattern to and and or methods.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ec2428 and 58092f2.

📒 Files selected for processing (9)

• crates/gh-workflow/src/cargo.rs (1 hunks)
• crates/gh-workflow/src/container.rs (1 hunks)
• crates/gh-workflow/src/ctx.rs (7 hunks)
• crates/gh-workflow/src/env.rs (3 hunks)
• crates/gh-workflow/src/job.rs (1 hunks)
• crates/gh-workflow/src/release_plz.rs (2 hunks)
• crates/gh-workflow/src/rust_flag.rs (2 hunks)
• crates/gh-workflow/src/step.rs (6 hunks)
• crates/gh-workflow/src/toolchain.rs (6 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: tusharmath
PR: tailcallhq/gh-workflow#97
File: crates/gh-workflow-tailcall/src/workflow.rs:121-121
Timestamp: 2024-12-10T06:33:21.046Z
Learning: In `crates/gh-workflow-tailcall/src/workflow.rs`, prefer converting standalone functions into methods of the `Workflow` struct when appropriate.

🧬 Code graph analysis (2)

crates/gh-workflow/src/cargo.rs (4)

crates/gh-workflow/src/job.rs (1)

• new (77-83)

crates/gh-workflow/src/step.rs (1)

• new (199-204)

crates/gh-workflow/src/expression.rs (1)

• new (13-15)

crates/gh-workflow/src/workflow.rs (1)

• new (113-115)

crates/gh-workflow/src/rust_flag.rs (1)

crates/gh-workflow/src/env.rs (2)

• from (17-19)
• from (48-52)

🔇 Additional comments (31)

crates/gh-workflow/src/job.rs (1)

25-26: LGTM! Consistent use of Self in constructor.

The change correctly applies the use_self lint suggestion in the From implementation.

crates/gh-workflow/src/env.rs (4)

17-18: LGTM! Proper use of Self in From implementation.

---

24-30: LGTM! Consistent constructor pattern.

---

34-35: LGTM! Proper use of Self::default().

---

48-51: LGTM! Consistent use of Self in tuple conversion.

crates/gh-workflow/src/container.rs (1)

81-84: LGTM! Consistent struct construction with Self.

crates/gh-workflow/src/release_plz.rs (2)

52-55: LGTM! Consistent use of Self in pattern matching.

---

66-70: LGTM! Consistent use of Self in pattern matching.

crates/gh-workflow/src/toolchain.rs (7)

19-23: LGTM! Consistent use of Self in Version Display.

---

28-29: LGTM! Proper constructor pattern.

---

42-46: LGTM! Consistent use of Self in Component Display.

---

61-67: LGTM! Consistent use of Self in Arch Display.

---

80-85: LGTM! Consistent use of Self in Vendor Display.

---

99-105: LGTM! Consistent use of Self in System Display.

---

119-125: LGTM! Consistent use of Self in Abi Display.

crates/gh-workflow/src/cargo.rs (1)

28-35: LGTM! Consistent use of Self in constructor.

Both the return type and construction properly use Self.

crates/gh-workflow/src/step.rs (7)

75-76: LGTM! Proper use of Self in From implementation.

---

164-165: LGTM! Consistent struct construction.

---

169-183: LGTM! Consistent struct construction.

---

199-203: LGTM! Proper use of Self in constructor.

---

225-226: LGTM! Consistent use of Self in return type.

---

246-250: LGTM! Proper use of Self in tuple conversion.

---

254-255: LGTM! Consistent use of Self in return type and construction.

crates/gh-workflow/src/rust_flag.rs (4)

26-29: LGTM! Proper use of Self in trait implementation.

---

34-52: LGTM! Consistent constructor pattern across all helper methods.

---

56-68: LGTM! Consistent use of Self in pattern matching.

---

72-76: LGTM! Proper use of Self::from() in conversion.

crates/gh-workflow/src/ctx.rs (4)

45-47: LGTM! Idiomatic use of Self in constructor.

The replacement of Context with Self is correct and improves consistency.

---

91-99: LGTM! Consistent use of Self throughout.

The method signature and constructor correctly use Self, and the implementation efficiently moves other.step since other is owned.

---

199-227: LGTM! Pattern matching correctly updated to use Self.

The replacement of Step:: with Self:: in all match arms is correct and makes the code more maintainable.

---

235-248: LGTM! From implementations correctly use Self.

Both trait implementations properly replace explicit type names with Self, improving consistency across the codebase.