android: Taildrop/share plain text (i.e. clipboard) #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified `loadFiles` by: * Creating extension functions for the wordy getParcelable*Extra methods * Shoring up some nullability checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tailscale/tailscale#16850
This enables the ability to share text (Taildrop) from Android, via the clipboard or any other text sharing intent. The relevant intent is already handled by the app, but plain text is just ignored.
This is a partial solution to my request here
An open question: what do you think of the generated filename
shared_text_[epoch].txt? I see the existing fallback filename when the filename is unknown is simply[epoch].txtbut it seemed appropriate to add a bit of context when it's known that the text is coming from a share intent instead of directly from a file on disk.