Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support <summary> as a focusable element #3389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shengslogar
Copy link

@shengslogar shengslogar commented Jul 16, 2024

  • <summary> is a built-in heading tag that is nested inside a <details> tag to toggle its contents. It's keyboard tab-able by default and not currently recognized by Headless UI.
  • There are no attributes that disable a summary tag, and adding tabindex="-1" makes it behave like any other normally-tab-able element.
  • I didn't spot any tests that specifically check for tab-ability of elements outside of buttons and inputs. Let me know if I missed anything.

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 11:27pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 11:27pm

@shengslogar
Copy link
Author

Should input type="hidden" also be on this list? From what I can tell logic will automatically loop past it either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant