Support class function hovers in Svelte and HTML <script> blocks
#1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
<script> blocks<script> blocks
thecrypticace
force-pushed
the
fix/class-functions-hover-in-script-tags
branch
from
14fc27d to
b4451e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
tailwindCSS.classFunctionssetting we were handling completions correctly inside<script>tags but not class hovers. This is b/c the code path for the two is just… different.It'll get unified eventually (soon hopefully) but until then this is the bug fix to ensure that hovering inside something like
<script>let classes = clsx("flex relative")</script>works