Fix Firefox code copying (2)#2126
Merged
philipp-spiess merged 4 commits intotailwindlabs:mainfrom Mar 5, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@wongjn seems like |
Contributor
|
Okay that was just the custom |
philipp-spiess
approved these changes
Mar 5, 2025
Merged
thecrypticace
added a commit
that referenced
this pull request
May 14, 2025
This basically reverts the FF fix from #2126 which fixed FF but broke word highlights. Also divs aren't allowed in `<code>` elements so Shiki's assumption that it really only needs to look inside `<span>`s isn't a terrible one in this case. We'll have to come up with some other solution to work around the FF bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #2120 that is simpler and (hopefully) without regressions!
Replaces
<span>elements for lines with<div>elements, since these seem to copy properly as newlines in Firefox. Though please note the HTML spec technically disallows this 😥.Fixes #1972
Closes #2120