Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align empty date/time inputs in Safari iOS #14977

Closed

Conversation

MartijnCuppens
Copy link
Contributor

Safari adds display: inline-flex to date/time inputs, and this causes some alignment issues to empty dates:

image

Issue demo: https://play.tailwindcss.com/5LRvozLfrJ

By setting the display to display: inline-block (like the other browsers), and changing the vertical alignment of a pseudo element, the alignment is fixed again:

image

Fix demo: https://play.tailwindcss.com/5juwgUQI6s

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner November 12, 2024 14:40
@philipp-spiess
Copy link
Member

Hey! Sorry for the super-late response here but we did look into this change in detail when we were working on consistent base styles for buttons and form controls that we ultimately decided to roll back because of how big the rabbit hole is that we uncovered.

Your specific changes looks good in the repro you said but once you start working with them (e.g. by adding a width since the empty input boxes do not have a width on iOS) you'll quickly uncover other issues like suddenly the height of the input changes: https://play.tailwindcss.com/K5xdRhnItD

D67EDC3D-74A5-4FBE-A725-C8962E6B58BD_1_101_o

Ultimately we have decided that Tailwind CSS is not something like Bootstrap and that users of Tailwind are expected to style their inputs, so we thought it's better to not be too prescriptive with the defaults here especially if it's only playing Whac-a-Mole. That's why we haven't merged in this PR for the v4 release.

Thank you for the PR though, really appreciate it! But

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants