Ensure escaped theme variables are handled correctly#16064
Merged
philipp-spiess merged 3 commits intomainfrom Jan 31, 2025
Merged
Ensure escaped theme variables are handled correctly#16064philipp-spiess merged 3 commits intomainfrom
philipp-spiess merged 3 commits intomainfrom
Conversation
a0c2186 to
e9c7140
Compare
adamwathan
reviewed
Jan 30, 2025
| ), | ||
| ).toMatchInlineSnapshot(` | ||
| ":root, :host { | ||
| --spacing-1_5: 2.5rem; |
Member
There was a problem hiding this comment.
Shouldn't this be --spacing-1\.5?
Contributor
Author
There was a problem hiding this comment.
@adamwathan Ah yeah I think you're right if they're defined with \. they should be CSS variables with \. just the lookup for 1_5 should also work 👍
f13d0d8 to
8c193dc
Compare
8c193dc to
c9afcbe
Compare
thecrypticace
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that escaped theme variables are properly handled. We do this by moving the
escape/unescaperesponsibility back into the main tailwindcss entrypoint that reads and writes from the CSS and making sure that _all internal state of theThemeclass are unescaped classes.However, due to us accidentally shipping the part where a dot in the theme variable would translate to an underscore in CSS already, this logic is going to stay as-is for now.
Here's an example test that visualizes the new changes:
Test plan
Added a unit test
Ensure this works end-to-end using the Vite playground: