Ignore Vite build output when scanning sources - #20484
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. WalkthroughThe Vite plugin passes the resolved build output directory to Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The change excludes generated output from automatic scanning while retaining explicit source scanning and watch rebuilds. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
vite build --watchloop.@sourcefiles beneath the output directory.vite@6.2.3, a customassetsoutput directory,emptyOutDir: false, and artifacts from a previous build.Fixes #17412.
Test plan
The packed-artifact regression was also checked against an unmodified current-main tarball. The baseline enters a second build immediately after the first; the candidate remains idle, honors an explicit source inside the output directory, then rebuilds normally after editing a real source file. Swapping back to the baseline makes the same test fail again.