Refactor/switch to logging #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 17, 2016 14:56
The socket is being held open by the writable handle. Close both the handle and the socket. To do this we need to store the handle as a member variable.
Rpdb now contains a Pdb instance instead of deriving from one. This lets the Rpdb object be created separately from the socket accept() call. Closes tamentis#4.
Setup and use Python's logging module instead of printing directly to stdout or stderr. Also, add an example program used for testing.
Collaborator
|
@shaleh, I know this issue is an age-old one, but I'm curious what problem this solved for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.