Skip to content

1094 - TYDE CoS - Circle view onboarding #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 219 commits into
base: tyde2
Choose a base branch
from
Open

1094 - TYDE CoS - Circle view onboarding #1095

wants to merge 219 commits into from

Conversation

@eabean
Copy link
Contributor

@eabean eabean commented Aug 3, 2021 •
edited
Loading

Changes

  • Adds circle view onboarding for the Circle of Support
  • Circle view is accessible only after a certain node is completed. This can be configured in the Settings tab under 'Advanced'

State Machine Diagram

This is the mindmap that will be used as the blueprint for implementation which closely follows the previous diagrams for the community view onboarding.
Circles (2)

Screenshot

Circle.View.Onboarding.Tapestry.-.Google.Chrome.2021-08-11.09-42-55.mp4

Issue Linkage

Closes (issue #1094 )

PR Dependency

Depends on: (PR #1072 )

Automated Testing

TYDE related feature, so no automated testing.

shirleywbi and others added 30 commits January 25, 2021 21:14
@shirleywbi
switch thumbnail URL sizes to 300
9cba4c5
@shirleywbi
Merge branch 'master' into 943-non-optimized-thumbnails-displayed
486bc71
@nandanmen
Merge branch 'master' into 943-non-optimized-thumbnails-displayed
feaf4e3
@wynnset
Install avataaars and add sample code
24ce57e
@wynnset
Merge branch 'master' into avataaars
c5ac477
@eabean
building Avatar customizer
1469dd5
@eabean
building Avatar customizer
65cd648
@eabean
basic Avatar customizer
f93493a
@eabean
Avatar Customizer Done
34f25b8
@eabean
added avatar form to settings
a15ac0f
@eabean
beginning saving avatar
0063b85
@eabean
PUT avatar working. Starting GET avatar.
44a633a
@eabean
basic AvatarForm working. GET implemented. Issues with async loading.
59dfa2d
@eabean
async load working
4416bfe
@eabean
clean up done. starting cypress tests
2c51851
@eabean
more clean up
1c162e1
@eabean
further cleaning up
9c78a90
@eabean
further cleaning up
b8514f8
@eabean
added environment variable for avatar popup
0d549a3
@eabean
Merge branch 'avataaars' of https://github.com/wynnset/tapestry-wp in…
9c668f1 
…to avataaars
@eabean
changed buttons and added cypress test
5814380
@eabean
lint fixes
3e7fe70
@eabean
migrated major CoS files
759684b
@eabean
migration complete
0bc6466
@EldadZZipori
Merge branch 'master' into avataaars
deeb2bd
@eabean
made CoS Button
273fb98
@eabean
change: CSS changes, lint fixes
fce9b80
@eabean
change: adding user setting modal
e801045
@eabean
user setting button set up
1ee78be
@eabean
change: all Avatar related modals only show if user is logged in and …
cedd83b 
…env variable is true
Base automatically changed from 1029-avataaars-copy to tyde2 September 21, 2021 22:31
@EldadZZipori EldadZZipori self-assigned this Sep 23, 2021
@EldadZZipori EldadZZipori added needs first review Code has not been reviewed yet needs testing Has been tested by author and needs a second pair of eyes to test it and removed needs work This PR has bugs or not complete as per its requirements labels Oct 1, 2021
@EldadZZipori EldadZZipori removed their assignment Oct 1, 2021
wynnset
wynnset requested changes Oct 5, 2021
View reviewed changes
@wynnset wynnset added needs refactoring Code refactoring required and removed needs testing Has been tested by author and needs a second pair of eyes to test it needs first review Code has not been reviewed yet labels Oct 6, 2021
@EldadZZipori EldadZZipori added needs first review Code has not been reviewed yet needs testing Has been tested by author and needs a second pair of eyes to test it and removed needs refactoring Code refactoring required labels Oct 7, 2021
@wynnset wynnset self-assigned this Oct 15, 2021
@wynnset
Copy link
Collaborator

wynnset commented Oct 20, 2021

There seem to be a lot of unrelated removal of new code or adding of code that was removed. I'm not sure how that's happened. We should verify which changes are actually related to this PR and remove everything else.

@wynnset wynnset added needs refactoring Code refactoring required and removed needs testing Has been tested by author and needs a second pair of eyes to test it needs first review Code has not been reviewed yet labels Oct 20, 2021
@wynnset wynnset removed their assignment Oct 20, 2021
@legendword legendword mentioned this pull request May 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wynnset wynnset wynnset requested changes

+1 more reviewer

@EldadZZipori EldadZZipori EldadZZipori left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs refactoring Code refactoring required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eabean @EldadZZipori @wynnset @shirleywbi @nandanmen @Frozemint