Skip to content

refactor: use setTimeout from timers module #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/base.js
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ const process = require('./process.js')
const assert = require('assert')
const util = require('util')
const {AsyncResource} = require('async_hooks')
const {clearTimeout, setTimeout} = require("timers");
const MiniPass = require('minipass')
const Domain = require('async-hook-domain')
const Parser = require('tap-parser')
41 changes: 41 additions & 0 deletions test/base.js
Original file line number Diff line number Diff line change
@@ -396,3 +396,44 @@ t.test('do not unnecessarily log uncaughts while bailing out', t => {
t.equal(b.read().toString('utf8'), 'TAP version 13\nnot ok\nBail out!\n')
t.end()
})

t.test("uses APIs from timers module", t => {
const { setTimeout, clearTimeout } = require('timers')
const mockTimers = {
timeoutsSet: [],
timeoutsCleared: [],
setTimeout: (fn, time) => {
const handle = setTimeout(fn, time)
mockTimers.timeoutsSet.push([handle, fn, time])
return handle
},
clearTimeout: (handle) => {
const ret = clearTimeout(handle)
mockTimers.timeoutsCleared.push(handle)
return ret
}
}

const Base = t.mock('../lib/base.js', { timers: mockTimers })
const b = new Base({name: 'timer mock test'})
let handle;
t.equal(mockTimers.timeoutsSet.length, 0)
t.equal(mockTimers.timeoutsCleared.length, 0)
b.setTimeout(1000)
handle = b.timer
t.equal(mockTimers.timeoutsSet.length, 1)
t.equal(mockTimers.timeoutsSet[0][0], handle)
t.equal(mockTimers.timeoutsSet[0][2], 1000)
b.setTimeout()
t.equal(mockTimers.timeoutsCleared.length, 1)
t.equal(mockTimers.timeoutsCleared[0], handle)
b.setTimeout(5000)
handle = b.timer
t.equal(mockTimers.timeoutsSet.length, 2)
t.equal(mockTimers.timeoutsSet[1][0], handle)
t.equal(mockTimers.timeoutsSet[1][2], 5000)
b.setTimeout()
t.equal(mockTimers.timeoutsCleared.length, 2)
t.equal(mockTimers.timeoutsCleared[1], handle)
t.end()
})