Skip to content

Add a detailed review of the key features in release 3.4 #5082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

lenkis
Copy link
Contributor

@lenkis lenkis commented Apr 18, 2025

No description provided.

Now supervised failover coordinator supports three bootstrap strategies:
native, supervised, auto.

The new ``native `` strategy acts more or less similar to the ``auto`` strategy,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: GitHub highlight this part is a bit strage way due to a whitespace before double backtick (after native). Not sure how it is rendered by Sphinx, but maybe it worth to drop the whitespace to be on the safe side.

record pointing to the instance that is currently in the RW mode (to register
new replicas).

To enable the ``native `` bootstrap strategy, set it in the ``replication`` section
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Same here regarding the whitespace.

Comment on lines +129 to +133
* issues ``box.ctl.make_bootstrap_leader({graceful = true})`` to bootstrap
a replicaset;
* issues ``box.ctl.make_bootstrap_leader()`` to keep the bootstrap leader
record pointing to the instance that is currently in the RW mode (to register
new replicas).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the calls under the hood are really interesting for our reader. Maybe some motivational things would work better here.

Quoted from my mini-announce in a team chat (in Russian):

Очень похоже на дефолтную auto, но под капотом работает по-другому (поверх стратегии supervised). Цель была в том, чтобы решить следующие проблемы:

  • Чтобы не стреляла ошибка Some replica set members were not specified in box.cfg.replication при одновременном подключении нескольких реплик, при наличии неанонимных CDC в репликасете, при наличии старых реплик в _cluster.
  • Чтобы база бутстрапилась по команде координатора, а не инстансами самостоятельно <...>.

Comment on lines +180 to +184
* ``has_role(<role_name>, {instance = <instance_name})`` returns ``true`` if
the instance with the name ``<instance_name>`` has the role ``<role_name>``
enabled in the current configuration, or ``false`` if not.
The second argument is optional: if not provided, the check is performed
for the instance the method is called on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It feels a bit too formal for the announcement. Would look appropriate in an API documentation, but here I would make it simpler:

config:has_role('myrole') tells whether the current instance has role myrole. config:has_role('myrole', {instance = 'i-001'}) do the same for the given instance.

Same for config:is_router(), config:is_storage().

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants