Skip to content

Remove entities used only by old decoder #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drewdzzz
Copy link
Collaborator

@drewdzzz drewdzzz commented Jul 16, 2025

See the commits for details.

Part of #93 reincarnation.

NB: the PR does a huge refactoring of the old codebase that is not formatted by clang-format, so it provides lots of warnings. Let's simply ignore them - all the PR does is deletion of unused entities.

The commits removes enums, classes and helpers that were used only
by the old decoder that was dropped in 54393a1.
Originally there were two family types: bitmask and compact. The first
one, bitmask, was used by the old decoder and was represented
as a bitmask (surprisingly). The second family type was represented as
an enum, so it was more compact then bitmask, hence, we called it
'compact'. It is used by the new codec.

Since we had the both codecs in our codebase at the same time, we had to
put compact family type to its own namespace, `compact`. But we've
removed the bitmask family type in the previous commit, so now let's
remove this 'compact' namespace and use enum-based family type as the
only one.

Personally, I find this 'compact' namespace consufing, especially for
users who don't know about this story with two codecs. So it's really
nice to finally remove this weird namespace.
@drewdzzz drewdzzz self-assigned this Jul 16, 2025
@drewdzzz drewdzzz assigned mkostoevr and CuriousGeorgiy and unassigned drewdzzz Jul 16, 2025
Copy link
Collaborator

@mkostoevr mkostoevr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always nice to see a code clean-up.

@mkostoevr mkostoevr removed their assignment Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants