Remove entities used only by old decoder #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commits removes enums, classes and helpers that were used only by the old decoder that was dropped in 54393a1.
Originally there were two family types: bitmask and compact. The first one, bitmask, was used by the old decoder and was represented as a bitmask (surprisingly). The second family type was represented as an enum, so it was more compact then bitmask, hence, we called it 'compact'. It is used by the new codec. Since we had the both codecs in our codebase at the same time, we had to put compact family type to its own namespace, `compact`. But we've removed the bitmask family type in the previous commit, so now let's remove this 'compact' namespace and use enum-based family type as the only one. Personally, I find this 'compact' namespace consufing, especially for users who don't know about this story with two codecs. So it's really nice to finally remove this weird namespace.
mkostoevr
approved these changes
Jul 25, 2025
CuriousGeorgiy
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commits for details.
Part of #93 reincarnation.
NB: the PR does a huge refactoring of the old codebase that is not formatted by
clang-format, so it provides lots of warnings. Let's simply ignore them - all the PR does is deletion of unused entities.