Draft
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Co-authored-by: Misieq01 <bartosz2000walczak@gmail.com>
## Description `get_key_manager()` will ask for PIN and decrypt cipherseed, if it is protected.
…3117) ## Description Runs transaction unlocker in background. Closes #3115 ## Motivation and Context We need to run transaction unlocker from the new wallet to revert expired locks for transactions. ## How Has This Been Tested? Started TU. ``` 09:49:49 INFO Starting Transaction Unlocker... ``` Stopped TU ``` 09:50:53 INFO Shutdown signal received. Stopping Transaction Unlocker. ```
## Description - fixed seedless `handle_new_block_height` emit in the setup loop - added back the scanning/syncing UI elements - implemented list virutalization properly (list should have been the direct child of the wrapper) - fixed the seedless UI wallet visual bug (#3101) - significant re-factoring of the Sidebar wallet components to resolve the above, but also for code readability, and small styling fixes - split sections from `SidebarWallet.tsx` out into their own components (eg. wallet details, swap panel handler) all handled in the new `wallet.tsx` file - thinned out and de-duped styling ## Motivation and Context - closes #3101 - sync & scanning UI was removed accidentally in the initial integration PR ## How Has This Been Tested? - locally: https://github.com/user-attachments/assets/bfe2ca7d-c2e8-492c-a750-dceb3f1aadce
## Description - re-implement new block height events with changes - remove coinbase tx checks from new block height event (was used on FE for **solo-mining** block win animations which are at this point very unlikely and no longer needed) - removed `handle_new_block_height` which handled the different ways we emmitted `EventsEmitter::emit_new_block_mined` and just emit directly from the node updates - ~~cleaned up the `useBlockTip` hook~~ moved `processNewBlock` to `useFetchExplorerData` & cleaned up the checks for more accurate timing between the explorer block change and when the node block comes in (only relevant if mining & visual mode is on) - removed dead code ## Motivation and Context - the events were commented out in initial integration, likely because `wallet_manager` changed so much and the previously used functions are no longer available with the new wallet ## How Has This Been Tested? - locally: **explorer x animation timing synced even if node block change comes in significantly earlier than explorer data:** https://github.com/user-attachments/assets/80bb5650-a26a-4544-99e2-ec4464ef8554
## Description - updated `minotari-cli` to [`4d39146`](tari-project/minotari-cli@4d39146) - adjusted `balance_tracker` items to suit - updated `minotari_wallet/mod.rs` - types as well as using tx id for pending txs - updated FE structs to suit
## Description - add minotari-cli wallet dir to `clean_data_folder` - fix the tx timestamp - only emit tx updates for confirmed transaction events - clear pending txs on refresh too ## How Has This Been Tested? - locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes