-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove redundant AC polyfill and use built-in UUID generator #3067
base: master
Are you sure you want to change the base?
refactor: remove redundant AC polyfill and use built-in UUID generator #3067
Conversation
…r instead of a 3rd party library
Thanks. Always great to get rid of dependencies! |
oops, forgot to replace uuid in tests, gimme a moment |
it seems like there are still some references to the uuid module. Btw, we will need to decide if this can be merged in current major version or if we will need to make a breaking release as there are potential users out there using lower than 16 in production. |
I'd say a breaking change would be better, as well as settings or in case you'd like to drop all EOL, |
@manast do I set the engines.node field to Node 16? or there is a better approach |
I think the engines.node is the most established way of doing this. |
@manast just added engines.node |
Why
uuid
as a package, since Node 16.7.0 thecrypto
module provides a safe generator for UUIDs.How
Removed both of the packages and replaced them with native functionality.
Additional Notes (Optional)
Tests pass locally on Node 18 / 20 / 22. Can't test on Node 16 because corepack is not compatible with it.