Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update Current Microsoft Browser to IE11/Edge #1796

Merged
merged 2 commits into from
Jun 3, 2018

Conversation

snuggs
Copy link

@snuggs snuggs commented Jul 7, 2017

📖 Update Current Microsoft Browser to IE11/Edge

Relative Issues

Fixes #1795 #autoclose
Addresses devpunks/snuggsi#85
Addresses devpunks/snuggsi#89

Description

Update current browser for Microsoft Internet Explorer / Edge.

This is due to the announcement early last year 2016 for removal of support from Internet Explorer versions < 11.

capture d ecran 2017-07-07 a 10 11 00

Read More Here
And Here

capture d ecran 2017-07-07 a 10 08 13

Would like to submit a todoMVC app but restricted to the most recent browsers which happens to be IE11

Much has changed in the past 12 months. #YaDontKnowWhatYaDontKnow

/cc @brandondees @tmornini @halorium @Robertchristopher @mrbernnz

Fixes tastejs#1785 #autoclose

Update current browser for Microsoft Internet Explorer / Edge.

This is due to the announcement early last year 2016 for removal of support from Internet Explorer versions < 11.

[Read More Here](https://www.microsoft.com/en-us/windowsforbusiness/end-of-ie-support)
And [Here](https://arstechnica.com/information-technology/2017/01/2016-on-the-web-firefox-fights-back-as-microsofts-share-slumps/)

Much has changed in the past 12 months. #YaDontKnowWhatYaDontKnow

/cc @brandondees @tmornini @halorium
@snuggs
Copy link
Author

snuggs commented Jul 7, 2017

Travis-CI Failure Reason

    ├── [email protected] deduped
    ├── [email protected] deduped
    └── [email protected] deduped


$ ./test-runner.sh


The command "./test-runner.sh" exited with 1.
store build cache

changes detected, packing new archive
uploading archive


Done. Your build exited with 1.

@snuggs snuggs changed the title Update current browser for Microsoft 📖 Update current browser for Microsoft to IE11/Edge Jul 7, 2017
@snuggs snuggs changed the title 📖 Update current browser for Microsoft to IE11/Edge 📖 Update Current Microsoft Browser to IE11/Edge Jul 7, 2017
@snuggs
Copy link
Author

snuggs commented Jul 7, 2017

Oh ok am sure you are aware of this. What do we need to do to get the build passing again?
capture d ecran 2017-07-07 a 10 21 32

Copy link
Collaborator

@FadySamirSadek FadySamirSadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@FadySamirSadek FadySamirSadek merged commit 0bcf448 into tastejs:master Jun 3, 2018
@snuggs snuggs deleted the patch-1 branch June 8, 2018 15:38
@snuggs
Copy link
Author

snuggs commented Jun 8, 2018

Wow I thought this would never get merged in. This is awesome! Now we can do our youtube video explaining todo mvc. @FadySamirSadek if there is anything you'd like our audience in NYC to know about the direction of todo MVC what message can we pass on to the (keyboard) troops?

Lastly, what's the deal with the failing test suite build? Been that way for about a year now.

And once again thanks a bunch. This actually unblocks us tremendously.

/cc @brandondees @tmornini

@FadySamirSadek
Copy link
Collaborator

@snuggs First of all thank you for your interest in contributing to TodoMVC. The project was not very active for a while as the maintainers were very busy with their day jobs and other stuff. I am now the lead maintainer and will be maintaining the project from now on and will do everything I can to get the project back on track and hopefully make it better and more friendly for new contributors. Regarding the project direction, I created an issue #1880 explaining everything we are planning to work on in V1.5. For the test suite, we managed to successfully migrate all the test suite from selenium (which was flakey) to cypress and working now to fix the issues that exist in some example so that the build passes again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

< IE 11 Considered End of Life
2 participants