Allow accessing older historical data#273
Draft
DGChahin wants to merge 2 commits intotastyware:masterfrom
Draft
Conversation
Graeme22
requested changes
Oct 4, 2025
Member
Graeme22
left a comment
There was a problem hiding this comment.
We used to support this but removed it as it looked to be broken! Good to know it's still possible to set an end date. You may also want to look at #198 and how the code looked before:
tastytrade/tastytrade/streamer.py
Line 470 in 967008d
Member
|
Hmm that's interesting, maybe try the streamer with |
Author
|
Tried with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The existing implementation of
subscribe_candledid not allow for settingtoTimeand it also didn't account for the unknown limitation that DxFeed/DxLink has: settingtho=Truemesses with the amount of available data via the feed (they told me via email).NOTE: I have NOT gone through the pre-merge checklist yet. I will try to go through it on Monday.
Pre-merge checklist
make lint)make test, make sure you haveTT_REFRESH,TT_SECRET, andTT_ACCOUNTenvironment variables set)Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.
EDIT: Apparently the
toTimesetting doesn't work with the Websocket, despite working with the web service. Will see if I find a way to make it work, because otherwise there's no way to get past the 8000 candle limit.