Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In fastping_test.go the address 127.0.0.100 is used to test non-response, but it is a valid loopback IP, and answer to pings (at least on Linux).
I replaced it with 198.51.100.100 (to keep the "100" spirit) which is an IP address from TEST-NET-2 (RFC 5737) which should never exist in production network, so there is little to no chance for it to answer when running tests.
There is also a sysctl config to change for UDP ping to work. (At least on debian-based ones, I tested on Ubuntu and Debian, haven't tested on others) and I added it to README