Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use Vite with SWC #581

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

feat: Use Vite with SWC #581

wants to merge 5 commits into from
+9 −4

Conversation

tomheaton
Copy link
Contributor

Use Vite with SWC for React templates.

I have not tested any mobile builds using the plugin.

Documentation for the plugin is available here.

@tomheaton tomheaton marked this pull request as ready for review January 18, 2024 20:32
@amrbashir
Copy link
Member

amrbashir commented Jan 18, 2024 •
edited
Loading

I am not a react dev and I am not sure if swc is the default option now in the react community but vite is still not including swc in their default react templates and we should stay in sync with them as our templates is mostly based on the vite ones.

Also the switch to react-swc plugin is simple enough, that it shouldn't bother those who use it by default (which I think is still a fairly less number of users than default react plugin)

@tomheaton
Copy link
Contributor Author

I agree, best to keep with vites current template.
Hopefully revisit in the future 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomheaton @amrbashir