feat: Optimize search requests with AbortController#209
Open
tony140407 wants to merge 2 commits intotauri-apps:devfrom
Open
feat: Optimize search requests with AbortController#209tony140407 wants to merge 2 commits intotauri-apps:devfrom
tony140407 wants to merge 2 commits intotauri-apps:devfrom
Conversation
- Implement AbortController to cancel previous requests when user types quickly - Fix race condition where stale responses could override newer results - Prevent unnecessary API calls by aborting outdated requests - Add proper cleanup on component unmount This improves performance when users type rapidly by ensuring only the latest search request is processed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Motivation
Currently, when users type quickly in the search box, multiple API requests
are sent simultaneously. This can cause:
🔧 Changes
AbortControllerto cancel previous search requests when a new one startssignalto the Meilisearch SDK search method (3rd parameter)AbortErrorgracefully without showing error statesonReset()calls in error handlers that could cancel active requests✅ Testing
Tested with:
📸 Screenshots
Happy to make any adjustments based on feedback! 😊