feat(log): Allow a log formatter per target #3065
Merged
+29
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
formatmethod toTarget, allowing each target to have a different formatter. It also addsreset_formatto the Builder to remove the default formatter.Motivation
When using the
with_colorsmethod with both a console-based and a file-based log target, the control codes for the colors are included in the log file. A custom formatter can be used when usingTargetKind::Dispatch, but then you lose out on the automatic file rotation that the plugin provides.Allowing a formatter per target solves this issue with techniques like the following: