-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(specta): don't use #[specta(rename = ...)] with tauri::ipc::Channel
#14812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specta): don't use #[specta(rename = ...)] with tauri::ipc::Channel
#14812
Conversation
Package Changes Through d7f4912There are 9 changes which include tauri with minor, @tauri-apps/cli with minor, tauri-cli with minor, tauri-utils with patch, tauri-build with patch, tauri-macos-sign with patch, tauri-bundler with minor, tauri-runtime-wry with minor, tauri-runtime with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
I think the change tag CI workflow is not working? I have got a changeset file which marks tauri as needing a patch but it's saying it doesn't. I don't think the Clippy failure is the fault of this PR. |
54ddb3a to
af4e7ad
Compare
For some reason we enforce patch types in this repo, so for example instead of
yeah, we didn't adapt to the 1.93 release from yesterday yet |
Updated the Tauri patch type to include 'bug' and fixed a Specta usage issue.
|
Ohhh, that makes sense! Updated the changeset. |
With some futures changes coming in the next Specta release this will cause problems.
This change of code is backwards compatible because Specta does something like
attributes.rename.unwrap_or_else(|| ident.to_string())so removing theattributes.renameis fine if we changeidentto match it's value.