fix(versioncheck): drop VersionPolicy for chains with no trackable image - #10
Merged
Merged
Conversation
Nine chains publish no public, version-tagged container image, so every versioncheck run logged them as permanent 404/403/auth ERRORs and the ChainVersionCatalog reconciler churned on unreachable registries: cronos, telos, fantom, wemix, shibarium — no official/public registry bittorrent, sonic, zircuit, moca — source-build or private only VersionProvider is an optional interface by design; dropping VersionPolicy from these adapters removes them from version tracking cleanly. The catalog controller already handles non-implementers gracefully (sets the VersionProviderNotImplemented condition). Pinned default images in versions_gen.go are untouched — nodes still deploy on the manual pin. Context: reconciled this against the moved-repo registry survey, where these nine kept returning 404/403 with no working replacement (unlike morph and dogecoin, which relocated). Confirmed via a full versioncheck run that all nine now drop out of the report while cronos-zkevm and the rest stay. Build, adapter and controller tests green. Spent ~1.5h verifying each repo had no public image before excluding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Nine chains publish no public, version-tagged container image. Every
versioncheckrun logged them as permanent 404/403/auth ERROR rows, and theChainVersionCatalogreconciler kept retrying unreachable registries. This removes theirVersionPolicy()so they drop out of version tracking.Why this approach
VersionProvideris an optional interface by design. DroppingVersionPolicy()from these adapters is the clean way to opt out — no skip-flags needed. The catalog controller already handles non-implementers gracefully (sets theVersionProviderNotImplementedcondition rather than erroring on a dead registry).Pinned default images in
versions_gen.goare untouched — nodes still deploy on the manually pinned image; only automated upstream tracking is disabled (there is no upstream to track).Verification
go build ./...,go test ./internal/adapters/,go test ./internal/controller/all passversioncheckrun confirms all nine drop out of the report, while legitimate chains (incl.cronos-zkevm) remain