add full_get_token_bytes #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tazz4843
requested changes
Sep 1, 2024
| if ret.is_null() { | ||
| return Err(WhisperError::NullPointer); | ||
| } | ||
| let c_str = unsafe { CStr::from_ptr(ret) }; |
There was a problem hiding this comment.
Given that both of these functions have the same fundamental calling code, can we merge the common code between _bytes and _text and call the common (private) function from both?
There was a problem hiding this comment.
I did it this way to copy how it was done for the existing full_get_segment_text/text_lossy/bytes functions. If the change is made here, it should probably also change for those functions to keep things consistent.
Thoughts?
There was a problem hiding this comment.
Oh wow I thought I responded to this forever ago, sorry about that. Yeah I think repeating this pattern on the others would be best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full_get_segment_bytes exists, but notfull_get_token_bytes.For non English languages, whisper can split tokens on non-valid UTF8 boundaries making finer grained parsing impossible with the current
textmethods.