Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

Editorial: use new IteratorStepValue AO #292

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Editorial: use new IteratorStepValue AO #292

merged 1 commit into from
Apr 5, 2024

Conversation

bakkot
Copy link
Collaborator

@bakkot bakkot commented Jan 31, 2024

tc39/ecma262#3268 lets us simplify use of the iteration protocol.

ljharb
ljharb reviewed Jan 31, 2024
View reviewed changes
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
ljharb added a commit to es-shims/iterator-helpers that referenced this pull request Jan 31, 2024
@ljharb
[Refactor] use IteratorStepValue
aa62d72 
See tc39/proposal-iterator-helpers#292
ljharb
ljharb approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes reviewed and validated against es-iterator-helpers.

flatMap was a bit tricky to map from the spec due to the hijinx i need to do to implement it in JS, but it works :-)

@michaelficarra michaelficarra merged commit b4ccc31 into main Apr 5, 2024
1 check passed
@michaelficarra michaelficarra deleted the iterator-step-value branch April 5, 2024 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ljharb ljharb ljharb approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bakkot @ljharb @michaelficarra