Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scopes: Make the offsets into the names array absolute #83

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

hbenl
Copy link
Collaborator

@hbenl hbenl commented Apr 25, 2024

At the last meeting we decided to make the offsets into the names array absolute for now until we have decided how to deal with #70 .
@jridgewell I also wanted to add you as a reviewer but for some reason Github won't let me.

@hbenl hbenl requested a review from szuend April 25, 2024 14:57
@hbenl hbenl self-assigned this Apr 25, 2024
@@ -206,11 +206,10 @@ Note: Each DATA represents one VLQ number.
* 0x1 has name
* name: (only exists if `has name` flag is set)
* DATA offset into `names` field
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify that these are absolute offsets?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clear enough that offsets are absolute if they're not explicitly specified to be relative. Anyway this will most likely change when we decide on #70 .

@hbenl hbenl merged commit f23f788 into main Apr 26, 2024
1 of 2 checks passed
@hbenl hbenl deleted the absolute-names-offsets branch April 26, 2024 08:38
github-actions bot added a commit that referenced this pull request Apr 26, 2024
SHA: f23f788
Reason: push, by hbenl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to szuend/source-map that referenced this pull request May 21, 2024
SHA: f23f788
Reason: push, by szuend

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants