Add a setting to specify the wikilink alias divider #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchayen
reviewed
Dec 30, 2020
tchayen
reviewed
Dec 30, 2020
|
This looks very good! Thanks for contributing. I didn't even know As you have mentioned, it is related to #28 in a way, but as it is a minor change in how we use a dependency and default option will be provided, I think we are good to go with introducing this change now. |
|
@tchayen I've fixed the two comments you had. Let me know if there's anything else! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially related to #28
remark-wiki-linkalready supports aliases using the default:divider. This adds a setting so that it can be changed.Use case
I use inlined ID-based (or Zettlr-style) links in my notes (e.g.:
[[20201231235959|some notes]]). I pair this extension with a Markdown previewer which only supports the MediaWiki syntax (using|).This will allow me to preview both my notes and graph correctly.
Known issues
Currently, changing this setting requires you to restart VS Code. I'm not sure of an elegant way to solve this, but it also shouldn't need to be changed too often.