Skip to content

Conversation

@jinukeu
Copy link
Member

@jinukeu jinukeu commented May 7, 2025

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

Summary by CodeRabbit

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ

    • ์•ฑ ์ „์ฒด์—์„œ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๋Š” ํ‘œ์ค€ ์ƒ‰์ƒ ํŒ”๋ ˆํŠธ์™€ ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์‹œ์Šคํ…œ์ด ๋„์ž…๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
    • ๋‹ค์–‘ํ•œ ์ƒ‰์ƒ(๋ธ”๋ž™, ํ™”์ดํŠธ, ๋ธ”๋ฃจ, ๊ทธ๋ฆฐ, ์˜ค๋ Œ์ง€, ๊ทธ๋ ˆ์ด ๋“ฑ)๊ณผ ์—๋Ÿฌ ์ƒ‰์ƒ์ด ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
    • ํ—ค๋”, ๋ณธ๋ฌธ, ์บก์…˜ ๋“ฑ ๋‹ค์–‘ํ•œ ํ…์ŠคํŠธ ์Šคํƒ€์ผ์ด ์ œ๊ณต๋˜์–ด ์ผ๊ด€๋œ ๋””์ž์ธ ์ ์šฉ์ด ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.
  • ํ™˜๊ฒฝ ์„ค์ •

    • iOS ์•ฑ ๊ฐœ๋ฐœ์„ ์œ„ํ•œ .gitignore ํŒŒ์ผ์ด ์ถ”๊ฐ€๋˜์–ด ๋ถˆํ•„์š”ํ•œ ํŒŒ์ผ์ด ์ €์žฅ์†Œ์— ํฌํ•จ๋˜์ง€ ์•Š๋„๋ก ๊ฐœ์„ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
    • Xcode ํ”„๋กœ์ ํŠธ ์„ค์ •์ด ์—…๋ฐ์ดํŠธ๋˜์–ด iOS ์ตœ์†Œ ์ง€์› ๋ฒ„์ „์ด 15.6์œผ๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ธฐํƒ€

    • ๋ถˆํ•„์š”ํ•œ ์‚ฌ์šฉ์ž๋ณ„ Xcode ๋ฐ์ดํ„ฐ ํŒŒ์ผ์ด ์ œ๊ฑฐ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

jinukeu added 3 commits May 6, 2025 23:33
- Added a standard .gitignore file for the iosApp directory to exclude build artifacts, user settings, and other generated files from version control.
- Added AppColor enum for common colors.
- Added color asset files for various shades of blue, green, orange, and gray, as well as black, white, primary, and error colors.
- Configured the project to include color assets.
- Added Typography struct and TextStyle struct for managing text styles.
- Added TypographyModifier view modifier for applying text styles.
- Added a View extension for easy application of typography styles.
- Added NotoSansKR font files (Bold, Light, Medium, Regular).
- Updated ContentView to use the new Typography and AppColor.
- Configured project settings to include the new font files and exclude Info.plist from file synchronization for the "suwiki" folder.
@jinukeu jinukeu requested a review from BEEEAM-J May 7, 2025 16:29
@jinukeu jinukeu self-assigned this May 7, 2025
@jinukeu jinukeu added the iOS label May 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 7, 2025

Walkthrough

์ด ๋ณ€๊ฒฝ์€ iOS ์•ฑ ํ”„๋กœ์ ํŠธ์— ๋””์ž์ธ ์‹œ์Šคํ…œ์˜ ๊ธฐ๋ฐ˜์„ ๊ตฌ์ถ•ํ•ฉ๋‹ˆ๋‹ค. ์ƒ‰์ƒ ๋ฐ ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ๋ฆฌ์†Œ์Šค๋ฅผ ์ถ”๊ฐ€ํ•˜๊ณ , SwiftUI์—์„œ ์ผ๊ด€๋œ ์Šคํƒ€์ผ๋ง์„ ์ ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก ๊ณตํ†ต ์ฝ”๋“œ์™€ ํ…Œ๋งˆ ํด๋ž˜์Šค๋ฅผ ๋„์ž…ํ–ˆ์œผ๋ฉฐ, ๊ด€๋ จ ๋ฆฌ์†Œ์Šค ํŒŒ์ผ ๋ฐ gitignore ๊ทœ์น™์„ ์ •๋น„ํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes

ํŒŒ์ผ/๊ฒฝ๋กœ ๊ทธ๋ฃน ๋ณ€๊ฒฝ ์š”์•ฝ
iosApp/.gitignore Xcode, Swift, ์˜์กด์„ฑ, ๋นŒ๋“œ ์‚ฐ์ถœ๋ฌผ, ์‚ฌ์šฉ์ž ์„ค์ • ๋“ฑ์„ ๋ฌด์‹œํ•˜๋Š” ๊ทœ์น™ ์ถ”๊ฐ€
iosApp/suwiki.xcodeproj/project.pbxproj .gitignore, ์ƒ‰์ƒ ์—์…‹ ๋“ฑ ์‹ ๊ทœ ๋ฆฌ์†Œ์Šค ํŒŒ์ผ ๋“ฑ๋ก, Info.plist ๊ฒฝ๋กœ ๋ฐ iOS ๋ฐฐํฌ ํƒ€๊ฒŸ ์ˆ˜์ •
iosApp/suwiki.xcodeproj/xcuserdata/.../xcschememanagement.plist ์‚ฌ์šฉ์ž๋ณ„ Xcode ์Šคํ‚ด ๊ด€๋ฆฌ ํŒŒ์ผ ์‚ญ์ œ
iosApp/suwiki/Assets.xcassets/Assets/*.colorset/Contents.json
iosApp/suwiki/Assets.xcassets/Assets/Contents.json
AppPrimary, AppBlack, AppWhite, Error, Blue/Green/Orange/Gray ๊ณ„์—ด ๋“ฑ ์ƒ‰์ƒ ์—์…‹ ๋ฐ ๋ฉ”ํƒ€๋ฐ์ดํ„ฐ ์ถ”๊ฐ€
iosApp/suwiki/ContentView.swift @EnvironmentObject๋กœ TypographyTheme ์ฃผ์ž…, ํ…์ŠคํŠธ ์ƒ‰์ƒ ๋ฐ ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์Šคํƒ€์ผ ์ ์šฉ
iosApp/suwiki/Presentation/Common/DesignSystem/AppColor.swift AppColor enum ์ถ”๊ฐ€, ์—์…‹ ๊ธฐ๋ฐ˜ ์ปฌ๋Ÿฌ static ํ”„๋กœํผํ‹ฐ ์ œ๊ณต
iosApp/suwiki/Presentation/Common/Theme/TypographyTheme.swift TypographyTheme ํด๋ž˜์Šค ์ถ”๊ฐ€, ๋‹ค์–‘ํ•œ ํ…์ŠคํŠธ ์Šคํƒ€์ผ ํ”„๋กœํผํ‹ฐ ์ œ๊ณต
iosApp/suwiki/Presentation/Common/Fonts/defaultTypography.swift SuwikiTypography, TextStyle, TypographyModifier, Font ํ™•์žฅ ๋“ฑ ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์‹œ์Šคํ…œ ๊ตฌํ˜„ ๋ฐ defaultTypography ์ธ์Šคํ„ด์Šค ์ถ”๊ฐ€
iosApp/suwiki/suwikiApp.swift TypographyTheme ์ธ์Šคํ„ด์Šค๋ฅผ ํ™˜๊ฒฝ ๊ฐ์ฒด๋กœ ๋ฃจํŠธ ๋ทฐ์— ์ฃผ์ž…

Sequence Diagram(s)

sequenceDiagram
    participant App as suwikiApp
    participant Env as Environment
    participant View as ContentView
    participant Theme as TypographyTheme
    participant Color as AppColor

    App->>Env: .environmentObject(TypographyTheme())
    Env->>View: ContentView()์— TypographyTheme ์ฃผ์ž…
    View->>Theme: typography.caption1 ์Šคํƒ€์ผ ์ฐธ์กฐ
    View->>Color: AppColor.grayDA ์ƒ‰์ƒ ์ฐธ์กฐ
    View->>View: Text("Hello, suwiki!")์— ์Šคํƒ€์ผ ์ ์šฉ
Loading

Assessment against linked issues

Objective Addressed Explanation
๋””์ž์ธ ์‹œ์Šคํ…œ ๊ตฌ์ถ• (#168) โœ…

Poem

๐Ÿฐ
์ƒˆ๋กœ ์˜จ ์ƒ‰๊ณผ ๊ธ€์”จ์˜ ์ถค,
ํ† ๋ผ๋Š” ํŒ”์ง ๋›ฐ๋ฉฐ ๋ถ€๋ฆ…๋‹ˆ๋‹คโ€”
๊ฒ€์ •, ํŒŒ๋ž‘, ์ดˆ๋ก, ์ฃผํ™ฉ, ํšŒ์ƒ‰๋น›
๋ชจ๋‘ ๋ชจ์—ฌ ์•ฑ์„ ๋ฌผ๋“ค์˜€๋„ค.
ํฐํŠธ๋„ ์˜ˆ์˜๊ฒŒ, ํ…Œ๋งˆ๋„ ๋ฐ˜์ง!
๋””์ž์ธ ์‹œ์Šคํ…œ, ์ด์ œ ์™„๋ฒฝ!

( ห˜โ–ฝห˜)ใฃ๐ŸŽจ


๐Ÿ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between e67327a and a244905.

๐Ÿ“’ Files selected for processing (2)
  • iosApp/suwiki/Presentation/Common/Fonts/defaultTypography.swift (1 hunks)
  • iosApp/suwiki/Presentation/Common/Theme/TypographyTheme.swift (1 hunks)
โœ… Files skipped from review due to trivial changes (1)
  • iosApp/suwiki/Presentation/Common/Fonts/defaultTypography.swift
๐Ÿšง Files skipped from review as they are similar to previous changes (1)
  • iosApp/suwiki/Presentation/Common/Theme/TypographyTheme.swift
โฐ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
โœจ Finishing Touches
  • ๐Ÿ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share
๐Ÿชง Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

๐Ÿ”ญ Outside diff range comments (1)
iosApp/suwiki.xcodeproj/project.pbxproj (1)

231-237: โš ๏ธ Potential issue

๋ฆฌ์†Œ์Šค ๋นŒ๋“œ ๋‹จ๊ณ„์—์„œ .gitignore ์ œ์™ธ ํ•„์š”
Resources Build Phase์—๋„ .gitignore๊ฐ€ ํฌํ•จ๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค. ์•ž์„œ ์ง€์ ํ•œ PBXBuildFile ์ œ๊ฑฐ์™€ ๋งˆ์ฐฌ๊ฐ€์ง€๋กœ, ๋ฆฌ์†Œ์Šค ๋นŒ๋“œ ๋‹จ๊ณ„์—์„œ๋„ ํ•ด๋‹น ํ•ญ๋ชฉ์„ ์‚ญ์ œํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

- 	9B9D7C0D2DCA53EA00C02045 /* .gitignore in Resources */,
๐Ÿงน Nitpick comments (9)
iosApp/suwiki/Assets.xcassets/Assets/GrayF6.colorset/Contents.json (1)

1-20: GrayF6 ์ƒ‰์ƒ ์—์…‹ ์ •์˜ ํ™•์ธ ๋ฐ ์Šน์ธ

์ƒˆ๋กœ์šด ์—์…‹ GrayF6๊ฐ€ sRGB ์ƒ‰์ƒ(0.965, 0.965, 0.965) ๋ฐ alpha 1.0์œผ๋กœ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. idiom์ด universal๋กœ ์ง€์ •๋˜์–ด ๋ชจ๋“  ๋””๋ฐ”์ด์Šค์—์„œ ์ผ๊ด€๋˜๊ฒŒ ์‚ฌ์šฉ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค. AppColor.grayF6 ๋˜๋Š” Color("GrayF6")๋กœ ์ •์ƒ ๋งคํ•‘๋˜๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.
๋‹คํฌ ๋ชจ๋“œ ์ง€์›์„ ์œ„ํ•ด ํ•„์š”์‹œ appearances ์„น์…˜์„ ์ถ”๊ฐ€ํ•ด ๋ผ์ดํŠธ/๋‹คํฌ ๋ณ€ํ˜•์„ ์ •์˜ํ•˜๋Š” ๊ฒƒ์„ ๊ณ ๋ คํ•ด์ฃผ์„ธ์š”.

iosApp/suwiki/Assets.xcassets/Assets/Error.colorset/Contents.json (1)

1-20: Error ์ƒ‰์ƒ ์—์…‹ ์ •์˜ ํ™•์ธ ๋ฐ ์Šน์ธ

์—์…‹ Error๊ฐ€ sRGB(0.941, 0.361, 0.180) ๋ฐ alpha 1.0์œผ๋กœ ์ •ํ™•ํ•˜๊ฒŒ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์˜ค๋ฅ˜๋‚˜ ๊ฒฝ๊ณ  ์ƒํƒœ ๊ฐ•์กฐ์šฉ์œผ๋กœ ์ง๊ด€์ ์ธ ์ปฌ๋Ÿฌ๊ฐ’์ž…๋‹ˆ๋‹ค. AppColor.error ๋˜๋Š” Color("Error")๋กœ ์ •์ƒ ๋งคํ•‘๋˜๋Š”์ง€ ํ™•์ธํ•˜๊ณ , ๋‹คํฌ ๋ชจ๋“œ ๋ณ€ํ˜•์ด ํ•„์š”ํ•˜๋ฉด appearances ํ•ญ๋ชฉ ์ถ”๊ฐ€๋ฅผ ๊ฒ€ํ† ํ•ด์ฃผ์„ธ์š”.

iosApp/suwiki/Assets.xcassets/Assets/Green10.colorset/Contents.json (1)

1-20: Green10 ์ƒ‰์ƒ ์—์…‹ ์ •์˜ ํ™•์ธ ๋ฐ ์Šน์ธ

์—์…‹ Green10์ด sRGB(0.918, 0.973, 0.925) ๋ฐ alpha 1.0์œผ๋กœ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์„ฑ๊ณต ์ƒํƒœ๋‚˜ ๊ฐ•์กฐ ์š”์†Œ์— ์ ์ ˆํ•œ ํ†ค์ž…๋‹ˆ๋‹ค. AppColor.green10 ๋˜๋Š” Color("Green10") ๋งคํ•‘์„ ํ™•์ธํ•˜๊ณ , ํ•„์š” ์‹œ ๋‹คํฌ ๋ชจ๋“œ variant๋ฅผ appearances๋กœ ์ถ”๊ฐ€ํ•ด ์ฃผ์„ธ์š”.

iosApp/suwiki/Assets.xcassets/Assets/Orange100.colorset/Contents.json (1)

1-20: Orange100 ์ƒ‰์ƒ ์—์…‹ ์ •์˜ ํ™•์ธ ๋ฐ ์Šน์ธ

์—์…‹ Orange100์ด sRGB(0.992, 0.529, 0.231) ๋ฐ alpha 1.0์œผ๋กœ ์ •ํ™•ํžˆ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ฃผ์š” ๋ฒ„ํŠผ์ด๋‚˜ ๊ฐ•์กฐ ์š”์†Œ์— ์ ํ•ฉํ•œ ์ปฌ๋Ÿฌํ†ค์ž…๋‹ˆ๋‹ค. AppColor.orange100 ๋˜๋Š” Color("Orange100") ๋งคํ•‘์„ ๊ฒ€์ฆํ•˜๊ณ , ๋‹คํฌ ๋ชจ๋“œ ์ง€์›์ด ํ•„์š”ํ•  ๊ฒฝ์šฐ appearances์— ๋‹คํฌ ๋ณ€ํ˜•์„ ์ถ”๊ฐ€ํ•ด ์ฃผ์„ธ์š”.

iosApp/suwiki/Assets.xcassets/Assets/Gray6A.colorset/Contents.json (1)

1-20: Gray6A ์ƒ‰์ƒ ์—์…‹ ์ •์˜ ํ™•์ธ ๋ฐ ์Šน์ธ

์—์…‹ Gray6A๊ฐ€ sRGB(0.416, 0.416, 0.416) ๋ฐ alpha 1.0์œผ๋กœ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๋ฐฐ๊ฒฝ ๋˜๋Š” ํ…Œ๋‘๋ฆฌ์šฉ์œผ๋กœ ํ™œ์šฉ ์‹œ ๋Œ€๋น„๋„(contrast ratio)๊ฐ€ ๋””์ž์ธยท์ ‘๊ทผ์„ฑ ๊ฐ€์ด๋“œ๋ผ์ธ(์˜ˆ: WCAG AA/AAA)์„ ๋งŒ์กฑํ•˜๋Š”์ง€ ๊ฒ€ํ† ํ•ด์ฃผ์„ธ์š”.
๋‹คํฌ ๋ชจ๋“œ variant๊ฐ€ ํ•„์š”ํ•˜๋‹ค๋ฉด appearances ์„น์…˜์„ ์ถ”๊ฐ€ํ•ด ์ฃผ์‹œ๊ณ , ๋Œ€๋น„ ๋น„์œจ์„ ํ™•์ธํ•œ ํ›„ ํ•„์š” ์‹œ ์ƒ‰์ƒ ์กฐ์ • ์ž‘์—…์„ ์ง„ํ–‰ํ•˜๋Š” ๊ฒƒ์„ ๊ถŒ์žฅ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

iosApp/.gitignore (1)

1-102: .gitignore ํŒจํ„ด ๊ฒ€ํ† 

  • iOS/Swift ๊ด€๋ จ ๋ถˆํ•„์š” ํŒŒ์ผ๋“ค์„ ์ž˜ ์ปค๋ฒ„ํ•˜๊ณ  ์žˆ์–ด ๊น”๋”ํ•ฉ๋‹ˆ๋‹ค.
  • Swift Package Manager(.build, Packages/, Package.resolved ๋“ฑ) ํ•ญ๋ชฉ์ด ์ฃผ์„ ์ฒ˜๋ฆฌ๋˜์–ด ์žˆ๋Š”๋ฐ, ์‹ค์ œ๋กœ SPM์„ ์‚ฌ์šฉํ•œ๋‹ค๋ฉด ํ•ด๋‹น ํŒจํ„ด์„ ํ™œ์„ฑํ™”ํ•ด๋„ ์ข‹์Šต๋‹ˆ๋‹ค.
  • ํ•„์š”์— ๋”ฐ๋ผ .swiftpm/, *.xcodeproj/xcuserdata/ ๊ฐ™์€ ์ถ”๊ฐ€ ํŒจํ„ด์„ ๊ฒ€ํ† ํ•ด๋ณด์„ธ์š”.
iosApp/suwiki/Presentation/Common/DesignSystem/AppColor.swift (1)

1-24: ์ปฌ๋Ÿฌ ๋„ค์ž„์ŠคํŽ˜์ด์Šค ๊ตฌํ˜„์€ ์ ์ ˆ

  • enum AppColor๋กœ ๋„ค์ž„์ŠคํŽ˜์ด์Šค๋งŒ ์ œ๊ณตํ•ด ์ธ์Šคํ„ด์Šคํ™” ๋ฐฉ์ง€ํ•œ ์ ์ด ์ข‹์Šต๋‹ˆ๋‹ค.
  • ์—์…‹ ์นดํƒˆ๋กœ๊ทธ์— ์ •์˜๋œ ์ƒ‰์„ ์ผ๊ด€๋˜๊ฒŒ ์ฐธ์กฐํ•  ์ˆ˜ ์žˆ์–ด ์œ ์ง€๋ณด์ˆ˜๊ฐ€ ์šฉ์ดํ•ฉ๋‹ˆ๋‹ค.

์ œ์•ˆ (์˜ต์…˜): ๋ฒˆ๋“ค ๋ช…์‹œ
๋ชจ๋“ˆ ๋ถ„๋ฆฌ ์‹œ ์™ธ๋ถ€ ๋ฒˆ๋“ค์—์„œ ์ƒ‰์ƒ์„ ๋ถˆ๋Ÿฌ์˜ฌ ์ˆ˜ ์žˆ๋„๋ก ๋‹ค์Œ๊ณผ ๊ฐ™์ด bundle: ํŒŒ๋ผ๋ฏธํ„ฐ๋ฅผ ๋ช…์‹œํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

static let primary = Color("AppPrimary", bundle: .main)
iosApp/suwiki/Presentation/Common/Fonts/Typography.swift (2)

10-34: ์ „์—ญ ์ƒ์ˆ˜ ๋ช…๋ช… ๊ทœ์น™ ๊ถŒ์žฅ์‚ฌํ•ญ

  • let Typography๋Š” ํƒ€์ž…๊ณผ ์œ ์‚ฌํ•œ ์ด๋ฆ„์ด๋ฏ€๋กœ ํ˜ผ๋™๋  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
  • Swift API Design Guidelines์— ๋”ฐ๋ผ ์ „์—ญ ์ƒ์ˆ˜๋Š” lowerCamelCase(let typography)๋‚˜ ๊ตฌ์ฒด์  ์ด๋ฆ„(defaultTypography)์œผ๋กœ ๋ณ€๊ฒฝ์„ ๊ณ ๋ คํ•ด์ฃผ์„ธ์š”.

37-61: SuwikiTypography ๊ตฌ์กฐ์ฒด: ํ™•์žฅ์„ฑ ํ™•์ธ

  • ํ—ค๋”, ๋ณธ๋ฌธ, ์บก์…˜์„ ๋ชจ๋‘ ํฌํ•จํ•ด ์ผ๊ด€์„ฑ ์žˆ๋Š” ์Šคํƒ€์ผ์„ ์ œ๊ณตํ•˜๋Š” ์ ์ด ์ข‹์Šต๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ƒˆ๋กœ์šด ํ…์ŠคํŠธ ๋ ˆ๋ฒจ ์ถ”๊ฐ€ ์‹œ ํ”„๋กœํผํ‹ฐ๊ฐ€ ๋งŽ์•„์งˆ ์ˆ˜ ์žˆ์œผ๋ฏ€๋กœ, ์ƒ์„ฑ์ž ํŒŒ๋ผ๋ฏธํ„ฐ๊ฐ€ ๋งŽ์•„์ง€๋Š” ๊ฒƒ์„ ๋ฐฉ์ง€ํ•˜๊ณ ์ž DSL ๋˜๋Š” ๋นŒ๋” ํŒจํ„ด ๋„์ž…์„ ๊ณ ๋ คํ•ด๋ณผ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between d4ab309 and e67327a.

โ›” Files ignored due to path filters (2)
  • iosApp/suwiki/Presentation/Common/Fonts/NotoSansKR-Bold.ttf is excluded by !**/*.ttf
  • iosApp/suwiki/Presentation/Common/Fonts/NotoSansKR-Light.ttf is excluded by !**/*.ttf
๐Ÿ“’ Files selected for processing (29)
  • iosApp/.gitignore (1 hunks)
  • iosApp/suwiki.xcodeproj/project.pbxproj (6 hunks)
  • iosApp/suwiki.xcodeproj/xcuserdata/jinukeu.xcuserdatad/xcschemes/xcschememanagement.plist (0 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/AppBlack.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/AppPrimary.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/AppWhite.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Blue10.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Blue100.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Blue30.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Blue5.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Error.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Gray6A.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Gray95.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/GrayCB.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/GrayDA.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/GrayF6.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/GrayFB.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Green10.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Green100.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Green30.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Orange10.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Orange100.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/Assets.xcassets/Assets/Orange30.colorset/Contents.json (1 hunks)
  • iosApp/suwiki/ContentView.swift (1 hunks)
  • iosApp/suwiki/Presentation/Common/DesignSystem/AppColor.swift (1 hunks)
  • iosApp/suwiki/Presentation/Common/Fonts/Typography.swift (1 hunks)
  • iosApp/suwiki/Presentation/Common/Theme/TypographyTheme.swift (1 hunks)
  • iosApp/suwiki/suwikiApp.swift (1 hunks)
๐Ÿ’ค Files with no reviewable changes (1)
  • iosApp/suwiki.xcodeproj/xcuserdata/jinukeu.xcuserdatad/xcschemes/xcschememanagement.plist
โฐ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
๐Ÿ”‡ Additional comments (32)
iosApp/suwiki/Assets.xcassets/Assets/Contents.json (1)

1-6: Asset ์นดํƒˆ๋กœ๊ทธ ๋ฉ”ํƒ€๋ฐ์ดํ„ฐ ์ •์ƒ ์ถ”๊ฐ€๋จ
Xcode ํ‘œ์ค€ ํ˜•์‹์œผ๋กœ ์ž‘์„ฑ๋œ JSON์ด๋ฉฐ, author์™€ version ํ•„๋“œ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์—์…‹ ์นดํƒˆ๋กœ๊ทธ ๋กœ๋”ฉ ์‹œ ๋ฌธ์ œ ์—†์ด ์ž‘๋™ํ•  ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/Gray95.colorset/Contents.json (1)

1-20: Gray95 ์ƒ‰์ƒ ์ž์‚ฐ JSON ์œ ํšจ์„ฑ ํ™•์ธ
sRGB ์ƒ‰์ƒ ์ปดํฌ๋„ŒํŠธ์™€ idiom, info ์„น์…˜์ด Xcode ์ž์‚ฐ ํ‘œ์ค€์— ๋งž๊ฒŒ ์ž‘์„ฑ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ƒ‰์ƒ ๊ฐ’(0.584)์ด ์ •ํ™•ํ•˜๊ฒŒ ๋ฐ˜์˜๋˜์–ด ๋””์ž์ธ ์‹œ์Šคํ…œ ๋‚ด์—์„œ ์ผ๊ด€๋œ AppColor.gray95 ๋งตํ•‘์ด ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/GrayDA.colorset/Contents.json (1)

1-20: GrayDA ์ƒ‰์ƒ ์ž์‚ฐ JSON ์œ ํšจ์„ฑ ํ™•์ธ
RGBA ๊ตฌ์„ฑ์š”์†Œ(0.855)์™€ idiom: universal ์„ค์ •์ด ์ ์ ˆํ•˜๋ฉฐ, AppColor.grayDA๋กœ์˜ ์ฐธ์กฐ ์‹œ ์˜๋„ํ•œ ์ƒ‰์ƒ ์ถœ๋ ฅ์ด ๋ณด์žฅ๋ฉ๋‹ˆ๋‹ค. JSON ์Šคํ‚ค๋งˆ๋„ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ค€์ˆ˜ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/Orange30.colorset/Contents.json (1)

1-20: Orange30 ์ƒ‰์ƒ ์ž์‚ฐ JSON ์œ ํšจ์„ฑ ํ™•์ธ
RGB(0.996, 0.859, 0.769) ๋ฐ alpha: 1.0 ๊ฐ’์ด ์ •ํ™•ํ•˜๋ฉฐ, idiom๊ณผ info๊ฐ€ Xcode ์—์…‹ ๊ทœ๊ฒฉ์— ๋ถ€ํ•ฉํ•ฉ๋‹ˆ๋‹ค. AppColor.orange30 ๋งคํ•‘ ์‹œ ์ •ํ™•ํ•œ ์ƒ‰์ƒ ๋ Œ๋”๋ง์ด ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/Orange10.colorset/Contents.json (1)

1-20: Orange10 ์ƒ‰์ƒ ์ž์‚ฐ JSON ์œ ํšจ์„ฑ ํ™•์ธ
sRGB ๊ตฌ์„ฑ์š”์†Œ(red:1.0, green:0.953, blue:0.922)์™€ author/version ํ•„๋“œ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๋””์ž์ธ ์‹œ์Šคํ…œ ํ†ตํ•ฉ์— ๋ฌธ์ œ ์—†์œผ๋ฉฐ, SwiftUI ์ฝ”๋“œ์—์„œ ๋ฐ”๋กœ ์‚ฌ์šฉ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/GrayCB.colorset/Contents.json (1)

1-20: ์ƒ‰์ƒ ์—์…‹ ์ถ”๊ฐ€ ์Šน์ธ!

ํšŒ์ƒ‰(GrayCB) ์ƒ‰์ƒ์ด ์„ฑ๊ณต์ ์œผ๋กœ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค. RGB ๊ฐ’ (0.796, 0.796, 0.796)์€ ์ค‘๊ฐ„ ํ†ค์˜ ํšŒ์ƒ‰์œผ๋กœ ๋””์ž์ธ ์‹œ์Šคํ…œ์— ์ ํ•ฉํ•ฉ๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/Blue30.colorset/Contents.json (1)

1-20: ์ƒ‰์ƒ ์—์…‹ ์ถ”๊ฐ€ ์Šน์ธ!

ํŒŒ๋ž€์ƒ‰(Blue30) ์ƒ‰์ƒ์ด ์„ฑ๊ณต์ ์œผ๋กœ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค. RGB ๊ฐ’ (0.773, 0.792, 0.996)์€ ๋ฐ์€ ํŒŒ๋ž€์ƒ‰ ๊ณ„์—ด๋กœ, ๋””์ž์ธ ์‹œ์Šคํ…œ์— ์ ํ•ฉํ•ฉ๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/Green100.colorset/Contents.json (1)

1-20: ์ƒ‰์ƒ ์—์…‹ ์ถ”๊ฐ€ ์Šน์ธ!

๋…น์ƒ‰(Green100) ์ƒ‰์ƒ์ด ์„ฑ๊ณต์ ์œผ๋กœ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค. RGB ๊ฐ’ (0.176, 0.725, 0.259)์€ ์„ ๋ช…ํ•œ ๋…น์ƒ‰์œผ๋กœ ๋””์ž์ธ ์‹œ์Šคํ…œ์— ์ ํ•ฉํ•ฉ๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/Blue10.colorset/Contents.json (1)

1-20: ์ƒ‰์ƒ ์—์…‹ ์ถ”๊ฐ€ ์Šน์ธ!

ํŒŒ๋ž€์ƒ‰(Blue10) ์ƒ‰์ƒ์ด ์„ฑ๊ณต์ ์œผ๋กœ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค. RGB ๊ฐ’ (0.925, 0.929, 1.000)์€ ๋งค์šฐ ์—ฐํ•œ ํŒŒ๋ž€์ƒ‰์œผ๋กœ ๋””์ž์ธ ์‹œ์Šคํ…œ์˜ ๋ฐฐ๊ฒฝ ์ƒ‰์ƒ ๋“ฑ์— ์ ํ•ฉํ•ฉ๋‹ˆ๋‹ค.

iosApp/suwiki/suwikiApp.swift (1)

15-15: TypographyTheme ์ถ”๊ฐ€ ํ™•์ธ ํ•„์š”

TypographyTheme ํ™˜๊ฒฝ ๊ฐ์ฒด๊ฐ€ ์„ฑ๊ณต์ ์œผ๋กœ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๊ทธ๋Ÿฌ๋‚˜ TypographyTheme ํด๋ž˜์Šค์— ๋Œ€ํ•œ import ๋ฌธ์ด ์—†๋Š” ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค. ์ปดํŒŒ์ผ ์˜ค๋ฅ˜๋ฅผ ๋ฐฉ์ง€ํ•˜๊ธฐ ์œ„ํ•ด ๊ด€๋ จ import ๋ฌธ์„ ์ถ”๊ฐ€ํ•ด ์ฃผ์„ธ์š”.

๋‹ค์Œ๊ณผ ๊ฐ™์ด import ๋ฌธ์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์ด ์ข‹์Šต๋‹ˆ๋‹ค:

import SwiftUI
+import ๋ชจ๋“ˆ๋ช… // TypographyTheme๊ฐ€ ์ •์˜๋œ ๋ชจ๋“ˆ
iosApp/suwiki/Assets.xcassets/Assets/Blue100.colorset/Contents.json (1)

1-21: โ€˜Blue100โ€™ ์ƒ‰์ƒ ์—์…‹์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

  • JSON ๊ตฌ์กฐ๊ฐ€ Xcode Asset ์นดํƒˆ๋กœ๊ทธ ์‚ฌ์–‘์— ๋ถ€ํ•ฉํ•ฉ๋‹ˆ๋‹ค.
  • RGB(0.239, 0.306, 0.984)์™€ alpha(1.000) ๊ฐ’์ด ์˜๋„ํ•œ ๋””์ž์ธ ํŒ”๋ ˆํŠธ๋ฅผ ์ •ํ™•ํžˆ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • idiom์ด universal๋กœ ์ง€์ •๋˜์–ด ๋ชจ๋“  ๋””๋ฐ”์ด์Šค์—์„œ ์ผ๊ด€๋œ ์‚ฌ์šฉ์ด ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.
iosApp/suwiki/Assets.xcassets/Assets/Blue5.colorset/Contents.json (1)

1-21: โ€˜Blue5โ€™ ์ƒ‰์ƒ ์—์…‹์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

  • JSON ๊ตฌ์กฐ์™€ ํ‚ค(colors, color-space, components, idiom, info) ๋ฐฐ์น˜๊ฐ€ ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค.
  • RGB(0.961, 0.973, 1.000) ๋ฐ alpha(1.000)๋กœ ๋””์ž์ธ ์˜๋„์— ๋งž๋Š” ์—ฐํ•œ ๋ธ”๋ฃจํ†ค์„ ์ž˜ ํ‘œํ˜„ํ•ฉ๋‹ˆ๋‹ค.
  • ๋ชจ๋“  ๋””๋ฐ”์ด์Šค์— ์ ์šฉ๋˜๋Š” universal idiom ์„ค์ •์ด ์ผ๊ด€์„ฑ์„ ๋ณด์žฅํ•ฉ๋‹ˆ๋‹ค.
iosApp/suwiki/Assets.xcassets/Assets/Green30.colorset/Contents.json (1)

1-21: โ€˜Green30โ€™ ์ƒ‰์ƒ ์—์…‹์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

  • Xcode Asset ์‚ฌ์–‘์„ ์ถฉ์กฑํ•˜๋Š” JSON ๊ตฌ์กฐ๋ฅผ ๋”ฐ๋ฅด๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.
  • RGB(0.753, 0.918, 0.776) ๋ฐ alpha(1.000)์ด ์˜๋„ํ•œ ๋””์ž์ธ ์‹œ์Šคํ…œ ํ†ค์— ๋ถ€ํ•ฉํ•ฉ๋‹ˆ๋‹ค.
  • idiom: universal๋กœ ์ง€์ •ํ•˜์—ฌ ๋‹ค์–‘ํ•œ ๋””๋ฐ”์ด์Šค์—์„œ ์ผ๊ด€๋œ UI ์ œ๊ณต์ด ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.
iosApp/suwiki/Assets.xcassets/Assets/AppWhite.colorset/Contents.json (1)

1-21: โ€˜AppWhiteโ€™ ์ƒ‰์ƒ ์—์…‹์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

  • JSON ํŒŒ์ผ์ด Xcode Asset ์นดํƒˆ๋กœ๊ทธ ๊ตฌ์กฐ๋ฅผ ์ค€์ˆ˜ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.
  • RGB(1.000, 1.000, 1.000) ๋ฐ alpha(1.000) ๊ฐ’์œผ๋กœ ์ˆœ๋ฐฑ์ƒ‰์„ ์ •ํ™•ํžˆ ํ‘œํ˜„ํ•ฉ๋‹ˆ๋‹ค.
  • idiom: universal ์„ค์ •์œผ๋กœ ๋ชจ๋“  ํ™˜๊ฒฝ์—์„œ ์ผ๊ด€๋œ ์‚ฌ์šฉ์ด ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.
iosApp/suwiki/Assets.xcassets/Assets/AppBlack.colorset/Contents.json (1)

1-21: โ€˜AppBlackโ€™ ์ƒ‰์ƒ ์—์…‹์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

  • JSON ๊ตฌ์กฐ์™€ ํ‚ค ์ด๋ฆ„์ด Xcode ๊ธฐ์ค€์— ๋งž๊ฒŒ ์ •์˜๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค.
  • RGB(0.133, 0.133, 0.133) ๋ฐ alpha(1.000) ๊ฐ’์ด ํ‘œ์ค€ ๋ธ”๋ž™ ํ†ค์œผ๋กœ ์ ์ ˆํžˆ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
  • universal idiom ์ง€์ •์œผ๋กœ ๋‹ค์–‘ํ•œ ๊ธฐ๊ธฐ ๋ฐ ํ™”๋ฉด์—์„œ ์ผ๊ด€๋œ ๋น„์ฃผ์–ผ์„ ์ œ๊ณตํ•ฉ๋‹ˆ๋‹ค.
iosApp/suwiki/Assets.xcassets/Assets/AppPrimary.colorset/Contents.json (1)

1-20: ์ƒˆ๋กœ์šด ์•ฑ ๊ธฐ๋ณธ ์ƒ‰์ƒ ์ž์‚ฐ์ด ์ž˜ ์ •์˜๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

๋””์ž์ธ ์‹œ์Šคํ…œ ๊ตฌ์ถ•์„ ์œ„ํ•œ ๊ธฐ๋ณธ ์ƒ‰์ƒ(primary color)์ด RGBA(0.204, 0.424, 0.992, 1.0)๋กœ ์ ์ ˆํ•˜๊ฒŒ ์ •์˜๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ์ƒ‰์ƒ์€ ์•ฑ ์ „์ฒด์—์„œ ์ผ๊ด€๋œ ์‹œ๊ฐ์  ์•„์ด๋ดํ‹ฐํ‹ฐ๋ฅผ ์ œ๊ณตํ•˜๋Š” ๋ฐ ์ค‘์š”ํ•œ ์—ญํ• ์„ ํ•  ๊ฒƒ์ž…๋‹ˆ๋‹ค.

iosApp/suwiki/Assets.xcassets/Assets/GrayFB.colorset/Contents.json (1)

1-20: GrayFB ์ƒ‰์ƒ ์ž์‚ฐ์ด ์ ์ ˆํ•˜๊ฒŒ ์„ค์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

๋ฐ์€ ํšŒ์ƒ‰ ์ƒ‰์ƒ(RGB: 0.984, 0.984, 0.984)์ด ์ ์ ˆํ•˜๊ฒŒ ์ •์˜๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ์ƒ‰์ƒ์€ ๋ฐฐ๊ฒฝ์ด๋‚˜ ๊ตฌ๋ถ„์„  ๋“ฑ์— ์‚ฌ์šฉํ•˜๊ธฐ์— ์ ํ•ฉํ•œ ๋งค์šฐ ๋ฐ์€ ํšŒ์ƒ‰ ํ†ค์ž…๋‹ˆ๋‹ค.

iosApp/suwiki/ContentView.swift (3)

12-13: ๋””์ž์ธ ์‹œ์Šคํ…œ ์ ์šฉ์„ ์œ„ํ•œ EnvironmentObject ์ถ”๊ฐ€๊ฐ€ ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค.

TypographyTheme์„ ํ™˜๊ฒฝ ๊ฐ์ฒด๋กœ ์„ ์–ธํ•˜์—ฌ ๋ทฐ ์ „์ฒด์—์„œ ์ผ๊ด€๋œ ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์Šคํƒ€์ผ์„ ์ ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก ํ•œ ์ ‘๊ทผ์ด ์ข‹์Šต๋‹ˆ๋‹ค.


20-21: ๋””์ž์ธ ์‹œ์Šคํ…œ ์š”์†Œ๊ฐ€ ์ ์ ˆํžˆ ์ ์šฉ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

AppColor.grayDA์™€ typography.caption1์„ ์ ์šฉํ•˜์—ฌ ๋””์ž์ธ ์‹œ์Šคํ…œ์„ ์ผ๊ด€๋˜๊ฒŒ ํ™œ์šฉํ•˜๋Š” ๋ฐฉ์‹์ด ์ข‹์Šต๋‹ˆ๋‹ค. ์ด๋Š” ํ–ฅํ›„ ์œ ์ง€๋ณด์ˆ˜์™€ ๋””์ž์ธ ์ผ๊ด€์„ฑ์— ๋„์›€์ด ๋  ๊ฒƒ์ž…๋‹ˆ๋‹ค.


29-29: Preview์— EnvironmentObject ์ฃผ์ž…์ด ์ž˜ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

Preview์— TypographyTheme์„ ํ™˜๊ฒฝ ๊ฐ์ฒด๋กœ ์ฃผ์ž…ํ•จ์œผ๋กœ์จ ๋ฏธ๋ฆฌ๋ณด๊ธฐ ํ™”๋ฉด์—์„œ๋„ ์‹ค์ œ ํ™˜๊ฒฝ๊ณผ ๋™์ผํ•˜๊ฒŒ ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ๊ฐ€ ํ‘œ์‹œ๋˜๋„๋ก ํ•œ ์ ์ด ์ข‹์Šต๋‹ˆ๋‹ค.

iosApp/suwiki/Presentation/Common/Theme/TypographyTheme.swift (4)

9-10: ObservableObject ํŒจํ„ด ์ ์šฉ์ด ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค.

TypographyTheme ํด๋ž˜์Šค๋ฅผ ObservableObject๋กœ ๊ตฌํ˜„ํ•˜์—ฌ SwiftUI์˜ ํ™˜๊ฒฝ ๊ฐ์ฒด๋กœ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๊ฒŒ ํ•œ ๊ฒƒ์ด ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค. final ํ‚ค์›Œ๋“œ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์ƒ์†์„ ๋ฐฉ์ง€ํ•œ ๊ฒƒ๋„ ์ข‹์€ ์ ‘๊ทผ์ž…๋‹ˆ๋‹ค.


11-17: header ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์Šคํƒ€์ผ ์ •์˜๊ฐ€ ์ฒด๊ณ„์ ์œผ๋กœ ๊ตฌ์„ฑ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

header1๋ถ€ํ„ฐ header7๊นŒ์ง€ ๋‹ค์–‘ํ•œ ํ—ค๋” ์Šคํƒ€์ผ์„ Typography ํด๋ž˜์Šค์˜ ์ •์  ๋ฉค๋ฒ„๋ฅผ ์ฐธ์กฐํ•˜์—ฌ ์ •์˜ํ•œ ๊ฒƒ์ด ์ฒด๊ณ„์ ์ด๊ณ  ์ผ๊ด€์„ฑ ์žˆ์Šต๋‹ˆ๋‹ค.


19-26: body ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์Šคํƒ€์ผ ์ •์˜๊ฐ€ ์ž˜ ๊ตฌ์„ฑ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

body1๋ถ€ํ„ฐ body7๊นŒ์ง€ ๋ณธ๋ฌธ ํ…์ŠคํŠธ๋ฅผ ์œ„ํ•œ ๋‹ค์–‘ํ•œ ์Šคํƒ€์ผ์„ ์ œ๊ณตํ•˜์—ฌ ์œ ์—ฐํ•œ ๋””์ž์ธ ์‹œ์Šคํ…œ์„ ๊ตฌ์ถ•ํ•œ ์ ์ด ์ข‹์Šต๋‹ˆ๋‹ค.


27-34: caption ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์Šคํƒ€์ผ ์ •์˜๊ฐ€ ์ฒด๊ณ„์ ์œผ๋กœ ๊ตฌํ˜„๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

caption1๋ถ€ํ„ฐ caption7๊นŒ์ง€ ๋ถ€๊ฐ€ ํ…์ŠคํŠธ๋ฅผ ์œ„ํ•œ ์Šคํƒ€์ผ์„ ์ผ๊ด€๋˜๊ฒŒ ์ •์˜ํ•˜์—ฌ ๋””์ž์ธ ์‹œ์Šคํ…œ์˜ ์™„์„ฑ๋„๋ฅผ ๋†’์˜€์Šต๋‹ˆ๋‹ค. ContentView์—์„œ ์ด๋ฏธ caption1์„ ํ™œ์šฉํ•˜๊ณ  ์žˆ์–ด ์‹ค์ œ ์ ์šฉ ์‚ฌ๋ก€๋„ ํ™•์ธ๋ฉ๋‹ˆ๋‹ค.

iosApp/suwiki.xcodeproj/project.pbxproj (4)

34-34: ํŒŒ์ผ ์ฐธ์กฐ ๊ฒฝ๋กœ ๊ฒ€์ฆ ์š”์ฒญ
.gitignore๊ฐ€ PBXFileReference๋กœ ๊ทธ๋ฃน์— ์ถ”๊ฐ€๋˜์—ˆ๋Š”๋ฐ sourceTree = "<group>" ๊ธฐ์ค€์œผ๋กœ ์‹ค์ œ ํŒŒ์ผ ๊ฒฝ๋กœ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ๋งคํ•‘๋˜๋Š”์ง€ ํ™•์ธํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค. Xcode์—์„œ ๋ถ‰์€์ƒ‰ ํŒŒ์ผ ์ฐธ์กฐ(Red file)๊ฐ€ ์ƒ๊ธฐ์ง€ ์•Š๋„๋ก ํ™•์ธํ•ด์ฃผ์„ธ์š”.


37-45: PBXFileSystemSynchronizedBuildFileExceptionSet ๋„์ž… ํ™•์ธ ํ•„์š”
Info.plist ๋™๊ธฐํ™” ์ œ์™ธ ์˜ˆ์™ธ ์…‹์„ ์ƒˆ๋กœ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋นŒ๋“œ ๋ฐ ํŒŒ์ผ ์‹œ์Šคํ…œ ๋™๊ธฐํ™” ๋™์ž‘์— ์˜ํ–ฅ์ด ์—†๋Š”์ง€, ํŠนํžˆ Xcode์˜ Incremental Build๋‚˜ Asset Catalog ๋™๊ธฐํ™”์— ๋ฌธ์ œ๊ฐ€ ์—†๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.


93-101: ๋ฉ”์ธ ๊ทธ๋ฃน์— .gitignore ์ถ”๊ฐ€ ๊ฒ€ํ†  ํ•„์š”
๋ฉ”์ธ PBXGroup children์— .gitignore๋ฅผ ํฌํ•จ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค. ํ”„๋กœ์ ํŠธ ํƒ์ƒ‰๊ธฐ์—์„œ ์˜ฌ๋ฐ”๋ฅธ ์œ„์น˜์— ๋…ธ์ถœ๋˜๋Š”์ง€, ํ•˜์œ„ ๊ทธ๋ฃน ๊ตฌ์กฐ ์œ„/์•„๋ž˜์— ํ˜ผ๋ž€์„ ์ฃผ์ง€๋Š” ์•Š๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์‹œ๊ธฐ ๋ฐ”๋ž๋‹ˆ๋‹ค.


445-452: INFOPLIST_FILE ๋ฐ IPHONEOS_DEPLOYMENT_TARGET ์„ค์ • ๋ณ€๊ฒฝ ํ™•์ธ

  • INFOPLIST_FILE์ด ๋ช…์‹œ์ ์œผ๋กœ suwiki/Info.plist๋กœ ์„ค์ •๋œ ๊ฒƒ์€ ์ข‹์Šต๋‹ˆ๋‹ค.
  • IPHONEOS_DEPLOYMENT_TARGET์ด 18.4์—์„œ 15.6์œผ๋กœ ํ•˜ํ–ฅ๋œ ๊ฒƒ์€ ๊ตฌ๋ฒ„์ „ ๊ธฐ๊ธฐ ํ˜ธํ™˜์„ฑ์— ์œ ๋ฆฌํ•ฉ๋‹ˆ๋‹ค.

๋‹ค๋งŒ ์ด ๋ณ€๊ฒฝ์ด iOS 15.6 ์ดํ•˜ ํ™˜๊ฒฝ์—์„œ์˜ ๋Ÿฐํƒ€์ž„ ์ด์Šˆ ๋˜๋Š” iOS 18.4 ์ตœ์‹  API ์‚ฌ์šฉ์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š๋Š”์ง€ ์ „์ฒด ํ…Œ์ŠคํŠธ๋ฅผ ํ†ตํ•ด ๊ฒ€์ฆํ•ด์ฃผ์„ธ์š”.

Also applies to: 476-483

iosApp/suwiki/Presentation/Common/Fonts/Typography.swift (4)

63-67: TextStyle ๊ตฌ์กฐ์ฒด ์ •์˜ ์ ์ ˆ

  • font, lineSpacing, color๋ฅผ ํ•œ๊ณณ์— ๋ฌถ์–ด ์žฌ์‚ฌ์šฉ์„ฑ์„ ๋†’์˜€์Šต๋‹ˆ๋‹ค.
  • ํ•„์š” ์‹œ ์ถ”๊ฐ€ ์†์„ฑ(e.g. letterSpacing)์„ ํ™•์žฅํ•˜๊ธฐ์—๋„ ์œ ์—ฐํ•ฉ๋‹ˆ๋‹ค.

69-77: TypographyModifier ๋ฐ View extension

  • ViewModifier๋กœ ์Šคํƒ€์ผ ์ ์šฉ์„ ์บก์Аํ™”ํ•œ ์ ์ด ์šฐ์ˆ˜ํ•ฉ๋‹ˆ๋‹ค.
  • .typography(_:) ๋ฉ”์„œ๋“œ๋ฅผ ํ†ตํ•ด ๊ฐ€๋…์„ฑ ๋†’์€ ๋ทฐ ๋นŒ๋”ฉ์ด ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.

80-84: View extension ๋„ค์ด๋ฐ

  • typography(_:)๋Š” ๋™์‚ฌํ˜• ๋ฉ”์„œ๋“œ ์ด๋ฆ„ ๊ฐ€์ด๋“œ๋ฅผ ๋”ฐ๋ฅด๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ์ข‹์Šต๋‹ˆ๋‹ค.

87-98: Font.notoSans ๊ตฌํ˜„ ํ™•์ธ

  • switch๋กœ weight๋ณ„ ํฐํŠธ ํŒŒ์ผ๋ช…์„ ๋งคํ•‘ํ•œ ๋ฐฉ์‹์ด ๋ช…ํ™•ํ•ฉ๋‹ˆ๋‹ค.
  • .default ์ผ€์ด์Šค์—์„œ Regular๋กœ ํด๋ฐฑ ์ฒ˜๋ฆฌํ•œ ์ ๋„ ์•ˆ์ „ํ•ฉ๋‹ˆ๋‹ค.

Comment on lines +9 to +11
/* Begin PBXBuildFile section */
9B9D7C0D2DCA53EA00C02045 /* .gitignore in Resources */ = {isa = PBXBuildFile; fileRef = 9B9D7C0C2DCA53E300C02045 /* .gitignore */; };
/* End PBXBuildFile section */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โš ๏ธ Potential issue

.gitignore ํŒŒ์ผ์ด ๋ฆฌ์†Œ์Šค๋กœ ํฌํ•จ๋œ ๋ฌธ์ œ
ํ˜„์žฌ PBXBuildFile ์„น์…˜์— .gitignore๊ฐ€ ๋ฆฌ์†Œ์Šค๋กœ ๋“ฑ๋ก๋˜์–ด ์žˆ์–ด ์•ฑ ๋นŒ๋“œ ์‹œ ๋ฒˆ๋“ค์— ์˜๋„์น˜ ์•Š๊ฒŒ ํฌํ•จ๋ฉ๋‹ˆ๋‹ค. ์ผ๋ฐ˜์ ์œผ๋กœ .gitignore๋Š” ๋ฒ„์ „ ๊ด€๋ฆฌ์šฉ ํŒŒ์ผ๋กœ ์•ฑ ๋ฆฌ์†Œ์Šค ๋ฒˆ๋“ค์— ํฌํ•จ๋˜์ง€ ์•Š์•„์•ผ ํ•ฉ๋‹ˆ๋‹ค.

๋‹ค์Œ๊ณผ ๊ฐ™์€ diff๋ฅผ ์ ์šฉํ•ด ๊ด€๋ จ PBXBuildFile ํ•ญ๋ชฉ์„ ์ œ๊ฑฐํ•ด์ฃผ์„ธ์š”:

- /* Begin PBXBuildFile section */
- 	9B9D7C0D2DCA53EA00C02045 /* .gitignore in Resources */ = {isa = PBXBuildFile; fileRef = 9B9D7C0C2DCA53E300C02045 /* .gitignore */; };
- /* End PBXBuildFile section */

Committable suggestion skipped: line range outside the PR's diff.

Renamed `Typography.swift` to `defaultTypography.swift` and the `Typography` constant within it to `defaultTypography`. This change clarifies that this is the default set of typography styles and allows for the potential introduction of other typography sets in the future. Updated `TypographyTheme.swift` to reference the new `defaultTypography` constant.
Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ios ๋””์ž์ธ ์‹œ์Šคํ…œ ๊ตฌ์ถ• ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค~

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@jinukeu jinukeu merged commit 42b8b42 into develop May 8, 2025
1 check failed
@jinukeu jinukeu deleted the feature/#168-designsystem branch May 8, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

๋””์ž์ธ ์‹œ์Šคํ…œ ๊ตฌ์ถ•

3 participants