ENGDESK-37949: fix inbound ice lite #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elhodred
requested review from
damirn,
dev-ryanc,
baloeng,
minhtuan1407-telnyx and
tajamulTelnyx
damirn
approved these changes
Mar 19, 2025
minhtuan1407-telnyx
approved these changes
Mar 20, 2025
Elhodred
changed the base branch from
telnyx/telephony/development-backup-032025
to
telnyx/telephony/development
dev-ryanc
requested changes
Mar 24, 2025
damirn
reviewed
Apr 10, 2025
| @@ -1516,7 +1516,7 @@ static void handle_ice(switch_rtp_t *rtp_session, switch_rtp_ice_t *ice, void *d | |||
| switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(rtp_session->session), SWITCH_LOG_WARNING, "Error sending STUN Binding Request on ICE candidate still unresponsive to %s:%u\n", from_host, from_port); | |||
| } | |||
| } | |||
| } else if (packet->header.type == SWITCH_STUN_BINDING_RESPONSE && (ice->type & ICE_LITE)) { | |||
| } else if (packet->header.type == SWITCH_STUN_BINDING_RESPONSE && (ice->type & ICE_LITE_INBOUND)) { | |||
There was a problem hiding this comment.
ICE-LITE won't be set ever, is a channel variable we have to specifically set to make FS to act as an ICE-LITE agent and we are not doing it for any flow. Moreover, it's a completely different flow not related to this change.
With ICE-LITE enabled, FS will never send a STUN BINDING REQUEST, so we won't receive responses
There was a problem hiding this comment.
BTW, I added that condition to check ICE_LITE in a previous PR when I misunderstood the purpose of ICE_LITE flag
dev-ryanc
approved these changes
Apr 10, 2025
damirn
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.