-
Notifications
You must be signed in to change notification settings - Fork 965
chore(node): update Node.js version to 24.20.0 #10555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GiladShoham
wants to merge
18
commits into
master
Choose a base branch
from
chore/update-nodejs-24
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3234caa
chore(node): update Node.js version to 24.6.0
GiladShoham 9204361
fix: update recommended and supported Node.js versions to <25.0.0
GiladShoham b1d719d
Merge branch 'master' into chore/update-nodejs-24-6-0
GiladShoham 87082b6
Merge master and update Node.js to 24.13.0
davidfirst 04a2f61
fix: correct MDX comment syntax and exclude from prettier
davidfirst 98a8da0
Merge branch 'master' into chore/update-nodejs-24-6-0
GiladShoham 24261fd
Merge branch 'master' into chore/update-nodejs-24-6-0
GiladShoham 7c4a283
Merge branch 'master' into chore/update-nodejs-24-6-0
GiladShoham 1a07c39
chore(node): bump Node.js to 24.18.1
GiladShoham aaaf52a
revert: drop unrelated MDX/prettierignore changes to keep branch scop…
GiladShoham 6ec1d09
Merge branch 'master' into chore/update-nodejs-24
GiladShoham 12f9871
Merge branch 'master' into chore/update-nodejs-24
GiladShoham 0069657
Merge branch 'master' into chore/update-nodejs-24
GiladShoham c1f1900
Merge branch 'master' into chore/update-nodejs-24
GiladShoham bbf91ab
Merge branch 'master' into chore/update-nodejs-24
GiladShoham bb963fc
chore(node): bump Node.js to 24.20.0
GiladShoham 1bbd4bf
fix(e2e): filter Node's own deprecation warnings from HttpHelper stde…
GiladShoham f9e58c2
Merge branch 'master' into chore/update-nodejs-24
GiladShoham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,8 +103,14 @@ export class HttpHelper { | |
| // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX! | ||
| this.httpProcess.stderr.on('data', (data) => { | ||
| if (this.helper.debugMode) console.log(`stderr: ${data}`); | ||
| stderrData += data.toString(); | ||
| this.stderr += data.toString(); | ||
| const str = data.toString(); | ||
| stderrData += str; | ||
| // `this.stderr` backs the "clean startup" assertions, so known-benign noise (e.g. Node's own | ||
| // deprecation warnings) is filtered here rather than in the raw `stderrData` used for debugging. | ||
| this.stderr += str | ||
| .split('\n') | ||
| .filter((line) => !this.shouldIgnoreHttpError(line)) | ||
| .join('\n'); | ||
|
Comment on lines
+110
to
+113
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. Chunked warnings evade filtering The stderr handler filters each arbitrary stream chunk independently, so a Node warning split across chunks may not match the ignore pattern and its errors text still fails the clean-startup assertion. Splitting and rejoining every chunk also discards trailing newlines, corrupting adjacent stderr output. Agent Prompt
|
||
| }); | ||
| this.httpProcess.on('close', (code) => { | ||
| if (this.helper.debugMode) console.log(`child process exited with code ${code}`); | ||
|
|
@@ -219,7 +225,10 @@ export class HttpHelper { | |
| } | ||
| shouldIgnoreHttpError(data: string): boolean { | ||
| const msgToIgnore = ['@rollup/plugin-replace']; | ||
| return msgToIgnore.some((str) => data.startsWith(str)); | ||
| // Node's own runtime warnings (e.g. the `url.parse()` DEP0169 notice added in Node 24, whose text | ||
| // contains the word "errors") are not startup failures and shouldn't trip the "clean stderr" checks. | ||
| const patternsToIgnore = [/\(node:\d+\)\s+\[\w+\]\s+(Deprecation)?Warning:/]; | ||
| return msgToIgnore.some((str) => data.startsWith(str)) || patternsToIgnore.some((re) => re.test(data)); | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| ARG BASE_IMAGE=node:22.14.0 | ||
| ARG BASE_IMAGE=node:24.20.0 | ||
| FROM $BASE_IMAGE | ||
| USER root | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Dangling circleci job refs
🐞 Bug☼ ReliabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools