feat: HEAD메서드 ping endpoint 추가 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a HEAD endpoint for the /ping route to support monitoring health checks.
- Added a HEAD route for /ping alongside the existing GET route using the same handler.
- Updates the router configuration to handle HEAD requests on the ping endpoint.
Comments suppressed due to low confidence (1)
internal/http/router/router.go:12
- Ensure that using the same handler for both GET and HEAD requests adheres to the HEAD method semantics, where a HEAD request should not return a response body. If the PingPong handler produces a body, consider adapting it for HEAD requests or verifying that the underlying framework suppresses the body as expected.
r.HEAD("/ping", handler.PingPong)
iamjooon2
approved these changes
Mar 20, 2025
report: Run #69
🎉 All tests passed! |
report: Run #70
🎉 All tests passed! |
report: Run #71
🎉 All tests passed! |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a HEAD method endpoint for monitoring purposes.
- Introduces a new HEAD handler for the /ping route.
- Registers the HEAD route in the router by mapping it to the new handler.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/http/handler/pinghandler.go | Added HEAD method handler (DoNoting) |
| internal/http/router/router.go | Registered the HEAD route for the /ping endpoint |
Comments suppressed due to low confidence (1)
internal/http/handler/pinghandler.go:9
- [nitpick] The function name 'DoNoting' appears to be a misspelling; consider renaming it to 'DoNothing' for clarity.
func DoNoting(context *gin.Context) {
report: Run #72
🎉 All tests passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
모니터링 테스트용 HEAD 메서드 추가